Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/x86: intel_pmt_crashlog: Fix incorrect macros

Fixes off-by-one bugs in the macro assignments for the crashlog control
bits. Was initially tested on emulation but bug revealed after testing on
silicon.

Fixes: 5ef9998c96b0 ("platform/x86: Intel PMT Crashlog capability driver")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20210317024455.3071477-2-david.e.box@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

David E. Box and committed by
Hans de Goede
d4dc4bf2 501bb68a

+6 -7
+6 -7
drivers/platform/x86/intel_pmt_crashlog.c
··· 23 23 #define CRASH_TYPE_OOBMSM 1 24 24 25 25 /* Control Flags */ 26 - #define CRASHLOG_FLAG_DISABLE BIT(27) 26 + #define CRASHLOG_FLAG_DISABLE BIT(28) 27 27 28 28 /* 29 - * Bits 28 and 29 control the state of bit 31. 29 + * Bits 29 and 30 control the state of bit 31. 30 30 * 31 - * Bit 28 will clear bit 31, if set, allowing a new crashlog to be captured. 32 - * Bit 29 will immediately trigger a crashlog to be generated, setting bit 31. 33 - * Bit 30 is read-only and reserved as 0. 31 + * Bit 29 will clear bit 31, if set, allowing a new crashlog to be captured. 32 + * Bit 30 will immediately trigger a crashlog to be generated, setting bit 31. 34 33 * Bit 31 is the read-only status with a 1 indicating log is complete. 35 34 */ 36 - #define CRASHLOG_FLAG_TRIGGER_CLEAR BIT(28) 37 - #define CRASHLOG_FLAG_TRIGGER_EXECUTE BIT(29) 35 + #define CRASHLOG_FLAG_TRIGGER_CLEAR BIT(29) 36 + #define CRASHLOG_FLAG_TRIGGER_EXECUTE BIT(30) 38 37 #define CRASHLOG_FLAG_TRIGGER_COMPLETE BIT(31) 39 38 #define CRASHLOG_FLAG_TRIGGER_MASK GENMASK(31, 28) 40 39