Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/mm: Fix range check in tlbflush debugfs interface

Since the shift count settable there is used for shifting values
of type "unsigned long", its value must not match or exceed
BITS_PER_LONG (otherwise the shift operations are undefined).

Similarly, the value must not be negative (but -1 must be
permitted, as that's the value used to distinguish the case of
the fine grained flushing being disabled).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Alex Shi <alex.shi@intel.com>
Link: http://lkml.kernel.org/r/5049B65C020000780009990C@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Jan Beulich and committed by
Ingo Molnar
d4c9dbc6 057237bb

+1 -1
+1 -1
arch/x86/mm/tlb.c
··· 320 320 if (kstrtos8(buf, 0, &shift)) 321 321 return -EINVAL; 322 322 323 - if (shift > 64) 323 + if (shift < -1 || shift >= BITS_PER_LONG) 324 324 return -EINVAL; 325 325 326 326 tlb_flushall_shift = shift;