Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

m68knommu: fix use of cpu_to_le() on IO access

Due to the different data endian requirements of different buses on
m68knommu variants we sometimes need to byte swap results for readX()
or values to writeX(). Currently the code uses cpu_to_le to do this,
resulting in sparse warnings like:

arch/m68k/include/asm/io_no.h:78:16: sparse: sparse: cast to restricted __le32

Some casting to force __le32 types would resolve but it looks to be
simpler to just switch to using the underlying swab32() to resolve.

Similarly handle the 16bit cases in these functions as well.

Reported-by: kernel test robot <lkp@intel.com>
CC: Marc Kleine-Budde <mkl@pengutronix.de>
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>

+4 -4
+4 -4
arch/m68k/include/asm/io_no.h
··· 67 67 { 68 68 if (cf_internalio(addr)) 69 69 return __raw_readw(addr); 70 - return __le16_to_cpu(__raw_readw(addr)); 70 + return swab16(__raw_readw(addr)); 71 71 } 72 72 73 73 #define readl readl ··· 75 75 { 76 76 if (cf_internalio(addr)) 77 77 return __raw_readl(addr); 78 - return __le32_to_cpu(__raw_readl(addr)); 78 + return swab32(__raw_readl(addr)); 79 79 } 80 80 81 81 #define writew writew ··· 84 84 if (cf_internalio(addr)) 85 85 __raw_writew(value, addr); 86 86 else 87 - __raw_writew(__cpu_to_le16(value), addr); 87 + __raw_writew(swab16(value), addr); 88 88 } 89 89 90 90 #define writel writel ··· 93 93 if (cf_internalio(addr)) 94 94 __raw_writel(value, addr); 95 95 else 96 - __raw_writel(__cpu_to_le32(value), addr); 96 + __raw_writel(swab32(value), addr); 97 97 } 98 98 99 99 #else