Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mei: bus: use mei_cldev_ prefix for the API functions

Use mei_cldev_ prefix for all mei client bus api functions
in order to resolve prefix conflict with functions that handle
client function and are defined in client.c

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Tomas Winkler and committed by
Greg Kroah-Hartman
d49dc5e7 89391382

+70 -67
+34 -33
drivers/misc/mei/bus.c
··· 165 165 } 166 166 167 167 /** 168 - * mei_cl_send - me device send (write) 168 + * mei_cldev_send - me device send (write) 169 169 * 170 170 * @cldev: me client device 171 171 * @buf: buffer to send ··· 173 173 * 174 174 * Return: written size in bytes or < 0 on error 175 175 */ 176 - ssize_t mei_cl_send(struct mei_cl_device *cldev, u8 *buf, size_t length) 176 + ssize_t mei_cldev_send(struct mei_cl_device *cldev, u8 *buf, size_t length) 177 177 { 178 178 struct mei_cl *cl = cldev->cl; 179 179 ··· 182 182 183 183 return __mei_cl_send(cl, buf, length, 1); 184 184 } 185 - EXPORT_SYMBOL_GPL(mei_cl_send); 185 + EXPORT_SYMBOL_GPL(mei_cldev_send); 186 186 187 187 /** 188 - * mei_cl_recv - client receive (read) 188 + * mei_cldev_recv - client receive (read) 189 189 * 190 190 * @cldev: me client device 191 191 * @buf: buffer to send ··· 193 193 * 194 194 * Return: read size in bytes of < 0 on error 195 195 */ 196 - ssize_t mei_cl_recv(struct mei_cl_device *cldev, u8 *buf, size_t length) 196 + ssize_t mei_cldev_recv(struct mei_cl_device *cldev, u8 *buf, size_t length) 197 197 { 198 198 struct mei_cl *cl = cldev->cl; 199 199 ··· 202 202 203 203 return __mei_cl_recv(cl, buf, length); 204 204 } 205 - EXPORT_SYMBOL_GPL(mei_cl_recv); 205 + EXPORT_SYMBOL_GPL(mei_cldev_recv); 206 206 207 207 /** 208 - * mei_bus_event_work - dispatch rx event for a bus device 208 + * mei_cl_bus_event_work - dispatch rx event for a bus device 209 209 * and schedule new work 210 210 * 211 211 * @work: work 212 212 */ 213 - static void mei_bus_event_work(struct work_struct *work) 213 + static void mei_cl_bus_event_work(struct work_struct *work) 214 214 { 215 215 struct mei_cl_device *cldev; 216 216 ··· 272 272 } 273 273 274 274 /** 275 - * mei_cl_register_event_cb - register event callback 275 + * mei_cldev_register_event_cb - register event callback 276 276 * 277 277 * @cldev: me client devices 278 278 * @event_cb: callback function ··· 283 283 * -EALREADY if an callback is already registered 284 284 * <0 on other errors 285 285 */ 286 - int mei_cl_register_event_cb(struct mei_cl_device *cldev, 287 - unsigned long events_mask, 288 - mei_cl_event_cb_t event_cb, void *context) 286 + int mei_cldev_register_event_cb(struct mei_cl_device *cldev, 287 + unsigned long events_mask, 288 + mei_cldev_event_cb_t event_cb, void *context) 289 289 { 290 290 int ret; 291 291 ··· 296 296 cldev->events_mask = events_mask; 297 297 cldev->event_cb = event_cb; 298 298 cldev->event_context = context; 299 - INIT_WORK(&cldev->event_work, mei_bus_event_work); 299 + INIT_WORK(&cldev->event_work, mei_cl_bus_event_work); 300 300 301 301 if (cldev->events_mask & BIT(MEI_CL_EVENT_RX)) { 302 302 ret = mei_cl_read_start(cldev->cl, 0, NULL); ··· 314 314 315 315 return 0; 316 316 } 317 - EXPORT_SYMBOL_GPL(mei_cl_register_event_cb); 317 + EXPORT_SYMBOL_GPL(mei_cldev_register_event_cb); 318 318 319 319 /** 320 - * mei_cl_get_drvdata - driver data getter 320 + * mei_cldev_get_drvdata - driver data getter 321 321 * 322 322 * @cldev: mei client device 323 323 * 324 324 * Return: driver private data 325 325 */ 326 - void *mei_cl_get_drvdata(const struct mei_cl_device *cldev) 326 + void *mei_cldev_get_drvdata(const struct mei_cl_device *cldev) 327 327 { 328 328 return dev_get_drvdata(&cldev->dev); 329 329 } 330 - EXPORT_SYMBOL_GPL(mei_cl_get_drvdata); 330 + EXPORT_SYMBOL_GPL(mei_cldev_get_drvdata); 331 331 332 332 /** 333 - * mei_cl_set_drvdata - driver data setter 333 + * mei_cldev_set_drvdata - driver data setter 334 334 * 335 335 * @cldev: mei client device 336 336 * @data: data to store 337 337 */ 338 - void mei_cl_set_drvdata(struct mei_cl_device *cldev, void *data) 338 + void mei_cldev_set_drvdata(struct mei_cl_device *cldev, void *data) 339 339 { 340 340 dev_set_drvdata(&cldev->dev, data); 341 341 } 342 - EXPORT_SYMBOL_GPL(mei_cl_set_drvdata); 342 + EXPORT_SYMBOL_GPL(mei_cldev_set_drvdata); 343 343 344 344 /** 345 345 * mei_cldev_uuid - return uuid of the underlying me client ··· 381 381 EXPORT_SYMBOL_GPL(mei_cldev_enabled); 382 382 383 383 /** 384 - * mei_cl_enable_device - enable me client device 384 + * mei_cldev_enable_device - enable me client device 385 385 * create connection with me client 386 386 * 387 387 * @cldev: me client device 388 388 * 389 389 * Return: 0 on success and < 0 on error 390 390 */ 391 - int mei_cl_enable_device(struct mei_cl_device *cldev) 391 + int mei_cldev_enable(struct mei_cl_device *cldev) 392 392 { 393 393 struct mei_device *bus = cldev->bus; 394 394 struct mei_cl *cl; ··· 428 428 429 429 return ret; 430 430 } 431 - EXPORT_SYMBOL_GPL(mei_cl_enable_device); 431 + EXPORT_SYMBOL_GPL(mei_cldev_enable); 432 432 433 433 /** 434 - * mei_cl_disable_device - disable me client device 434 + * mei_cldev_disable - disable me client device 435 435 * disconnect form the me client 436 436 * 437 437 * @cldev: me client device 438 438 * 439 439 * Return: 0 on success and < 0 on error 440 440 */ 441 - int mei_cl_disable_device(struct mei_cl_device *cldev) 441 + int mei_cldev_disable(struct mei_cl_device *cldev) 442 442 { 443 443 struct mei_device *bus; 444 444 struct mei_cl *cl; ··· 476 476 mutex_unlock(&bus->device_lock); 477 477 return err; 478 478 } 479 - EXPORT_SYMBOL_GPL(mei_cl_disable_device); 479 + EXPORT_SYMBOL_GPL(mei_cldev_disable); 480 480 481 481 /** 482 482 * mei_cl_device_find - find matching entry in the driver id table ··· 663 663 } 664 664 static DEVICE_ATTR_RO(modalias); 665 665 666 - static struct attribute *mei_cl_dev_attrs[] = { 666 + static struct attribute *mei_cldev_attrs[] = { 667 667 &dev_attr_name.attr, 668 668 &dev_attr_uuid.attr, 669 669 &dev_attr_version.attr, 670 670 &dev_attr_modalias.attr, 671 671 NULL, 672 672 }; 673 - ATTRIBUTE_GROUPS(mei_cl_dev); 673 + ATTRIBUTE_GROUPS(mei_cldev); 674 674 675 675 /** 676 676 * mei_cl_device_uevent - me client bus uevent handler ··· 704 704 705 705 static struct bus_type mei_cl_bus_type = { 706 706 .name = "mei", 707 - .dev_groups = mei_cl_dev_groups, 707 + .dev_groups = mei_cldev_groups, 708 708 .match = mei_cl_device_match, 709 709 .probe = mei_cl_device_probe, 710 710 .remove = mei_cl_device_remove, ··· 937 937 dev_dbg(bus->dev, "rescan end"); 938 938 } 939 939 940 - int __mei_cl_driver_register(struct mei_cl_driver *cldrv, struct module *owner) 940 + int __mei_cldev_driver_register(struct mei_cl_driver *cldrv, 941 + struct module *owner) 941 942 { 942 943 int err; 943 944 ··· 954 953 955 954 return 0; 956 955 } 957 - EXPORT_SYMBOL_GPL(__mei_cl_driver_register); 956 + EXPORT_SYMBOL_GPL(__mei_cldev_driver_register); 958 957 959 - void mei_cl_driver_unregister(struct mei_cl_driver *cldrv) 958 + void mei_cldev_driver_unregister(struct mei_cl_driver *cldrv) 960 959 { 961 960 driver_unregister(&cldrv->driver); 962 961 963 962 pr_debug("mei: driver [%s] unregistered\n", cldrv->driver.name); 964 963 } 965 - EXPORT_SYMBOL_GPL(mei_cl_driver_unregister); 964 + EXPORT_SYMBOL_GPL(mei_cldev_driver_unregister); 966 965 967 966 968 967 int __init mei_cl_bus_init(void)
+13 -12
drivers/nfc/mei_phy.c
··· 118 118 cmd.sub_command = MEI_NFC_SUBCMD_IF_VERSION; 119 119 120 120 MEI_DUMP_NFC_HDR("version", &cmd.hdr); 121 - r = mei_cl_send(phy->cldev, (u8 *)&cmd, sizeof(struct mei_nfc_cmd)); 121 + r = mei_cldev_send(phy->cldev, (u8 *)&cmd, sizeof(struct mei_nfc_cmd)); 122 122 if (r < 0) { 123 123 pr_err("Could not send IF version cmd\n"); 124 124 return r; ··· 132 132 if (!reply) 133 133 return -ENOMEM; 134 134 135 - bytes_recv = mei_cl_recv(phy->cldev, (u8 *)reply, if_version_length); 135 + bytes_recv = mei_cldev_recv(phy->cldev, (u8 *)reply, if_version_length); 136 136 if (bytes_recv < 0 || bytes_recv < sizeof(struct mei_nfc_reply)) { 137 137 pr_err("Could not read IF version\n"); 138 138 r = -EIO; ··· 186 186 connect->vendor_id = phy->vendor_id; 187 187 188 188 MEI_DUMP_NFC_HDR("connect request", &cmd->hdr); 189 - r = mei_cl_send(phy->cldev, (u8 *)cmd, connect_length); 189 + r = mei_cldev_send(phy->cldev, (u8 *)cmd, connect_length); 190 190 if (r < 0) { 191 191 pr_err("Could not send connect cmd %d\n", r); 192 192 goto err; 193 193 } 194 194 195 - bytes_recv = mei_cl_recv(phy->cldev, (u8 *)reply, connect_resp_length); 195 + bytes_recv = mei_cldev_recv(phy->cldev, (u8 *)reply, 196 + connect_resp_length); 196 197 if (bytes_recv < 0) { 197 198 r = bytes_recv; 198 199 pr_err("Could not read connect response %d\n", r); ··· 239 238 MEI_DUMP_NFC_HDR("send", hdr); 240 239 241 240 memcpy(mei_buf + MEI_NFC_HEADER_SIZE, buf, length); 242 - err = mei_cl_send(phy->cldev, mei_buf, length + MEI_NFC_HEADER_SIZE); 241 + err = mei_cldev_send(phy->cldev, mei_buf, length + MEI_NFC_HEADER_SIZE); 243 242 if (err < 0) 244 243 goto out; 245 244 ··· 279 278 struct mei_nfc_hdr *hdr; 280 279 int received_length; 281 280 282 - received_length = mei_cl_recv(phy->cldev, buf, length); 281 + received_length = mei_cldev_recv(phy->cldev, buf, length); 283 282 if (received_length < 0) 284 283 return received_length; 285 284 ··· 338 337 if (phy->powered == 1) 339 338 return 0; 340 339 341 - r = mei_cl_enable_device(phy->cldev); 340 + r = mei_cldev_enable(phy->cldev); 342 341 if (r < 0) { 343 342 pr_err("Could not enable device %d\n", r); 344 343 return r; ··· 356 355 goto err; 357 356 } 358 357 359 - r = mei_cl_register_event_cb(phy->cldev, BIT(MEI_CL_EVENT_RX), 358 + r = mei_cldev_register_event_cb(phy->cldev, BIT(MEI_CL_EVENT_RX), 360 359 nfc_mei_event_cb, phy); 361 360 if (r) { 362 361 pr_err("Event cb registration failed %d\n", r); ··· 369 368 370 369 err: 371 370 phy->powered = 0; 372 - mei_cl_disable_device(phy->cldev); 371 + mei_cldev_disable(phy->cldev); 373 372 return r; 374 373 } 375 374 ··· 379 378 380 379 pr_info("%s\n", __func__); 381 380 382 - mei_cl_disable_device(phy->cldev); 381 + mei_cldev_disable(phy->cldev); 383 382 384 383 phy->powered = 0; 385 384 } ··· 401 400 402 401 phy->cldev = cldev; 403 402 init_waitqueue_head(&phy->send_wq); 404 - mei_cl_set_drvdata(cldev, phy); 403 + mei_cldev_set_drvdata(cldev, phy); 405 404 406 405 return phy; 407 406 } ··· 409 408 410 409 void nfc_mei_phy_free(struct nfc_mei_phy *phy) 411 410 { 412 - mei_cl_disable_device(phy->cldev); 411 + mei_cldev_disable(phy->cldev); 413 412 kfree(phy); 414 413 } 415 414 EXPORT_SYMBOL_GPL(nfc_mei_phy_free);
+3 -3
drivers/nfc/microread/mei.c
··· 57 57 58 58 static int microread_mei_remove(struct mei_cl_device *cldev) 59 59 { 60 - struct nfc_mei_phy *phy = mei_cl_get_drvdata(cldev); 60 + struct nfc_mei_phy *phy = mei_cldev_get_drvdata(cldev); 61 61 62 62 microread_remove(phy->hdev); 63 63 ··· 88 88 89 89 pr_debug(DRIVER_DESC ": %s\n", __func__); 90 90 91 - r = mei_cl_driver_register(&microread_driver); 91 + r = mei_cldev_driver_register(&microread_driver); 92 92 if (r) { 93 93 pr_err(MICROREAD_DRIVER_NAME ": driver registration failed\n"); 94 94 return r; ··· 99 99 100 100 static void microread_mei_exit(void) 101 101 { 102 - mei_cl_driver_unregister(&microread_driver); 102 + mei_cldev_driver_unregister(&microread_driver); 103 103 } 104 104 105 105 module_init(microread_mei_init);
+3 -3
drivers/nfc/pn544/mei.c
··· 55 55 56 56 static int pn544_mei_remove(struct mei_cl_device *cldev) 57 57 { 58 - struct nfc_mei_phy *phy = mei_cl_get_drvdata(cldev); 58 + struct nfc_mei_phy *phy = mei_cldev_get_drvdata(cldev); 59 59 60 60 pr_info("Removing pn544\n"); 61 61 ··· 88 88 89 89 pr_debug(DRIVER_DESC ": %s\n", __func__); 90 90 91 - r = mei_cl_driver_register(&pn544_driver); 91 + r = mei_cldev_driver_register(&pn544_driver); 92 92 if (r) { 93 93 pr_err(PN544_DRIVER_NAME ": driver registration failed\n"); 94 94 return r; ··· 99 99 100 100 static void pn544_mei_exit(void) 101 101 { 102 - mei_cl_driver_unregister(&pn544_driver); 102 + mei_cldev_driver_unregister(&pn544_driver); 103 103 } 104 104 105 105 module_init(pn544_mei_init);
+17 -16
include/linux/mei_cl_bus.h
··· 8 8 struct mei_cl_device; 9 9 struct mei_device; 10 10 11 - typedef void (*mei_cl_event_cb_t)(struct mei_cl_device *cldev, 12 - u32 events, void *context); 11 + typedef void (*mei_cldev_event_cb_t)(struct mei_cl_device *cldev, 12 + u32 events, void *context); 13 13 14 14 /** 15 15 * struct mei_cl_device - MEI device handle ··· 45 45 char name[MEI_CL_NAME_SIZE]; 46 46 47 47 struct work_struct event_work; 48 - mei_cl_event_cb_t event_cb; 48 + mei_cldev_event_cb_t event_cb; 49 49 void *event_context; 50 50 unsigned long events_mask; 51 51 unsigned long events; ··· 67 67 int (*remove)(struct mei_cl_device *cldev); 68 68 }; 69 69 70 - int __mei_cl_driver_register(struct mei_cl_driver *cldrv, struct module *owner); 71 - #define mei_cl_driver_register(cldrv) \ 72 - __mei_cl_driver_register(cldrv, THIS_MODULE) 70 + int __mei_cldev_driver_register(struct mei_cl_driver *cldrv, 71 + struct module *owner); 72 + #define mei_cldev_driver_register(cldrv) \ 73 + __mei_cldev_driver_register(cldrv, THIS_MODULE) 73 74 74 - void mei_cl_driver_unregister(struct mei_cl_driver *cldrv); 75 + void mei_cldev_driver_unregister(struct mei_cl_driver *cldrv); 75 76 76 - ssize_t mei_cl_send(struct mei_cl_device *cldev, u8 *buf, size_t length); 77 - ssize_t mei_cl_recv(struct mei_cl_device *cldev, u8 *buf, size_t length); 77 + ssize_t mei_cldev_send(struct mei_cl_device *cldev, u8 *buf, size_t length); 78 + ssize_t mei_cldev_recv(struct mei_cl_device *cldev, u8 *buf, size_t length); 78 79 79 - int mei_cl_register_event_cb(struct mei_cl_device *cldev, 80 - unsigned long event_mask, 81 - mei_cl_event_cb_t read_cb, void *context); 80 + int mei_cldev_register_event_cb(struct mei_cl_device *cldev, 81 + unsigned long event_mask, 82 + mei_cldev_event_cb_t read_cb, void *context); 82 83 83 84 #define MEI_CL_EVENT_RX 0 84 85 #define MEI_CL_EVENT_TX 1 ··· 88 87 const uuid_le *mei_cldev_uuid(const struct mei_cl_device *cldev); 89 88 u8 mei_cldev_ver(const struct mei_cl_device *cldev); 90 89 91 - void *mei_cl_get_drvdata(const struct mei_cl_device *cldev); 92 - void mei_cl_set_drvdata(struct mei_cl_device *cldev, void *data); 90 + void *mei_cldev_get_drvdata(const struct mei_cl_device *cldev); 91 + void mei_cldev_set_drvdata(struct mei_cl_device *cldev, void *data); 93 92 94 - int mei_cl_enable_device(struct mei_cl_device *cldev); 95 - int mei_cl_disable_device(struct mei_cl_device *cldev); 93 + int mei_cldev_enable(struct mei_cl_device *cldev); 94 + int mei_cldev_disable(struct mei_cl_device *cldev); 96 95 bool mei_cldev_enabled(struct mei_cl_device *cldev); 97 96 98 97 #endif /* _LINUX_MEI_CL_BUS_H */