Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev/cobalt-lcd: Initialize fb_ops to fbdev I/O-memory helpers

Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-11-tzimmermann@suse.de

+3
+1
drivers/video/fbdev/Kconfig
··· 1752 1752 config FB_COBALT 1753 1753 tristate "Cobalt server LCD frame buffer support" 1754 1754 depends on FB && MIPS_COBALT 1755 + select FB_IOMEM_HELPERS 1755 1756 1756 1757 config FB_SH7760 1757 1758 bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
+2
drivers/video/fbdev/cobalt_lcdfb.c
··· 280 280 .fb_read = cobalt_lcdfb_read, 281 281 .fb_write = cobalt_lcdfb_write, 282 282 .fb_blank = cobalt_lcdfb_blank, 283 + __FB_DEFAULT_IOMEM_OPS_DRAW, 283 284 .fb_cursor = cobalt_lcdfb_cursor, 285 + __FB_DEFAULT_IOMEM_OPS_MMAP, 284 286 }; 285 287 286 288 static int cobalt_lcdfb_probe(struct platform_device *dev)