Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: allegro: Annotate struct mcu_msg_push_buffers_internal with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for
struct mcu_msg_push_buffers_internal.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Michael Tretter <m.tretter@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Kees Cook and committed by
Hans Verkuil
d4255578 61334819

+1 -1
+1 -1
drivers/media/platform/allegro-dvt/allegro-mail.h
··· 184 184 struct mcu_msg_header header; 185 185 u32 channel_id; 186 186 size_t num_buffers; 187 - struct mcu_msg_push_buffers_internal_buffer buffer[]; 187 + struct mcu_msg_push_buffers_internal_buffer buffer[] __counted_by(num_buffers); 188 188 }; 189 189 190 190 struct mcu_msg_put_stream_buffer {