Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

block/blk-tag.c: Remove useless kfree

Remove useless kfree() and clean up code related to the removal.

The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
position p1,p2;
expression x;
@@

if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }

@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@

if (x@p1 == NULL) { ... when != I(x,...) S
when != e = e1
when != e += e1
when != e -= e1
when != ++e
when != --e
when != e++
when != e--
when != &e
kfree@p2(x); ... return ...; }

@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@

... when != true x@p1 == NULL
kfree@p2(x);

@depends on !ok && unchanged@
position r.p2;
expression x;
@@

*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Peter Senna Tschudin and committed by
Jens Axboe
d41570b7 e32463b2

+2 -4
+2 -4
block/blk-tag.c
··· 186 186 tags = __blk_queue_init_tags(q, depth); 187 187 188 188 if (!tags) 189 - goto fail; 189 + return -ENOMEM; 190 + 190 191 } else if (q->queue_tags) { 191 192 rc = blk_queue_resize_tags(q, depth); 192 193 if (rc) ··· 204 203 queue_flag_set_unlocked(QUEUE_FLAG_QUEUED, q); 205 204 INIT_LIST_HEAD(&q->tag_busy_list); 206 205 return 0; 207 - fail: 208 - kfree(tags); 209 - return -ENOMEM; 210 206 } 211 207 EXPORT_SYMBOL(blk_queue_init_tags); 212 208