Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

omfs: sparse annotations

Missing cpu_to_be64 on some constant assignments.
fs/omfs/dir.c:107:16: warning: incorrect type in assignment (different base types)
fs/omfs/dir.c:107:16: expected restricted __be64 [usertype] i_sibling
fs/omfs/dir.c:107:16: got unsigned long long
fs/omfs/file.c:33:13: warning: incorrect type in assignment (different base types)
fs/omfs/file.c:33:13: expected restricted __be64 [usertype] e_next
fs/omfs/file.c:33:13: got unsigned long long
fs/omfs/file.c:36:24: warning: incorrect type in assignment (different base types)
fs/omfs/file.c:36:24: expected restricted __be64 [usertype] e_cluster
fs/omfs/file.c:36:24: got unsigned long long
fs/omfs/file.c:37:23: warning: incorrect type in assignment (different base types)
fs/omfs/file.c:37:23: expected restricted __be64 [usertype] e_blocks
fs/omfs/file.c:37:23: got unsigned long long

fs/omfs/bitmap.c:74:18: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:74:18: expected unsigned long volatile *addr
fs/omfs/bitmap.c:74:18: got long *<noident>
fs/omfs/bitmap.c:77:20: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:77:20: expected unsigned long volatile *addr
fs/omfs/bitmap.c:77:20: got long *<noident>
fs/omfs/bitmap.c:112:17: warning: incorrect type in argument 2 (different signedness)
fs/omfs/bitmap.c:112:17: expected unsigned long volatile *addr
fs/omfs/bitmap.c:112:17: got long *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Harvey Harrison and committed by
Linus Torvalds
d406f66d 32be1d22

+7 -7
+3 -3
fs/omfs/bitmap.c
··· 71 71 } 72 72 if (set) { 73 73 set_bit(bit, sbi->s_imap[map]); 74 - set_bit(bit, (long *) bh->b_data); 74 + set_bit(bit, (unsigned long *)bh->b_data); 75 75 } else { 76 76 clear_bit(bit, sbi->s_imap[map]); 77 - clear_bit(bit, (long *) bh->b_data); 77 + clear_bit(bit, (unsigned long *)bh->b_data); 78 78 } 79 79 } 80 80 mark_buffer_dirty(bh); ··· 109 109 if (!bh) 110 110 goto out; 111 111 112 - set_bit(bit, (long *) bh->b_data); 112 + set_bit(bit, (unsigned long *)bh->b_data); 113 113 mark_buffer_dirty(bh); 114 114 brelse(bh); 115 115 }
+1 -1
fs/omfs/dir.c
··· 104 104 105 105 oi = (struct omfs_inode *) bh->b_data; 106 106 oi->i_head.h_self = cpu_to_be64(inode->i_ino); 107 - oi->i_sibling = ~0ULL; 107 + oi->i_sibling = ~cpu_to_be64(0ULL); 108 108 109 109 mark_buffer_dirty(bh); 110 110 brelse(bh);
+3 -3
fs/omfs/file.c
··· 30 30 { 31 31 struct omfs_extent *oe = (struct omfs_extent *) &bh->b_data[offset]; 32 32 33 - oe->e_next = ~0ULL; 33 + oe->e_next = ~cpu_to_be64(0ULL); 34 34 oe->e_extent_count = cpu_to_be32(1), 35 35 oe->e_fill = cpu_to_be32(0x22), 36 - oe->e_entry.e_cluster = ~0ULL; 37 - oe->e_entry.e_blocks = ~0ULL; 36 + oe->e_entry.e_cluster = ~cpu_to_be64(0ULL); 37 + oe->e_entry.e_blocks = ~cpu_to_be64(0ULL); 38 38 } 39 39 40 40 int omfs_shrink_inode(struct inode *inode)