Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: usb: aqc111: debug info before sanitation

If we sanitize error returns, the debug statements need
to come before that so that we don't lose information.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Fixes: 405b0d610745 ("net: usb: aqc111: fix error handling of usbnet read calls")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Oliver Neukum and committed by
David S. Miller
d3faab9b 27eab4c6

+4 -4
+4 -4
drivers/net/usb/aqc111.c
··· 31 31 USB_RECIP_DEVICE, value, index, data, size); 32 32 33 33 if (unlikely(ret < size)) { 34 - ret = ret < 0 ? ret : -ENODATA; 35 - 36 34 netdev_warn(dev->net, 37 35 "Failed to read(0x%x) reg index 0x%04x: %d\n", 38 36 cmd, index, ret); 37 + 38 + ret = ret < 0 ? ret : -ENODATA; 39 39 } 40 40 41 41 return ret; ··· 50 50 USB_RECIP_DEVICE, value, index, data, size); 51 51 52 52 if (unlikely(ret < size)) { 53 - ret = ret < 0 ? ret : -ENODATA; 54 - 55 53 netdev_warn(dev->net, 56 54 "Failed to read(0x%x) reg index 0x%04x: %d\n", 57 55 cmd, index, ret); 56 + 57 + ret = ret < 0 ? ret : -ENODATA; 58 58 } 59 59 60 60 return ret;