Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio-tz1090: Replace commas with semi-colons

Replace commas with semicolons between irqchip callback initialisation
statements in tz1090_gpio_bank_probe. The commas appear to be a subtle
remnant of when the irqchips were statically initialised.

Thanks to Thomas Gleixner for spotting it while whipping up a coccinelle
script.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-metag@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

James Hogan and committed by
Linus Walleij
d3e14453 f438acdf

+14 -14
+14 -14
drivers/gpio/gpio-tz1090.c
··· 488 488 gc->chip_types[0].handler = handle_level_irq; 489 489 gc->chip_types[0].regs.ack = REG_GPIO_IRQ_STS; 490 490 gc->chip_types[0].regs.mask = REG_GPIO_IRQ_EN; 491 - gc->chip_types[0].chip.irq_startup = gpio_startup_irq, 492 - gc->chip_types[0].chip.irq_ack = irq_gc_ack_clr_bit, 493 - gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit, 494 - gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit, 495 - gc->chip_types[0].chip.irq_set_type = gpio_set_irq_type, 496 - gc->chip_types[0].chip.irq_set_wake = gpio_set_irq_wake, 497 - gc->chip_types[0].chip.flags = IRQCHIP_MASK_ON_SUSPEND, 491 + gc->chip_types[0].chip.irq_startup = gpio_startup_irq; 492 + gc->chip_types[0].chip.irq_ack = irq_gc_ack_clr_bit; 493 + gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit; 494 + gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit; 495 + gc->chip_types[0].chip.irq_set_type = gpio_set_irq_type; 496 + gc->chip_types[0].chip.irq_set_wake = gpio_set_irq_wake; 497 + gc->chip_types[0].chip.flags = IRQCHIP_MASK_ON_SUSPEND; 498 498 499 499 /* edge chip type */ 500 500 gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH; 501 501 gc->chip_types[1].handler = handle_edge_irq; 502 502 gc->chip_types[1].regs.ack = REG_GPIO_IRQ_STS; 503 503 gc->chip_types[1].regs.mask = REG_GPIO_IRQ_EN; 504 - gc->chip_types[1].chip.irq_startup = gpio_startup_irq, 505 - gc->chip_types[1].chip.irq_ack = irq_gc_ack_clr_bit, 506 - gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit, 507 - gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit, 508 - gc->chip_types[1].chip.irq_set_type = gpio_set_irq_type, 509 - gc->chip_types[1].chip.irq_set_wake = gpio_set_irq_wake, 510 - gc->chip_types[1].chip.flags = IRQCHIP_MASK_ON_SUSPEND, 504 + gc->chip_types[1].chip.irq_startup = gpio_startup_irq; 505 + gc->chip_types[1].chip.irq_ack = irq_gc_ack_clr_bit; 506 + gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit; 507 + gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit; 508 + gc->chip_types[1].chip.irq_set_type = gpio_set_irq_type; 509 + gc->chip_types[1].chip.irq_set_wake = gpio_set_irq_wake; 510 + gc->chip_types[1].chip.flags = IRQCHIP_MASK_ON_SUSPEND; 511 511 512 512 /* Setup chained handler for this GPIO bank */ 513 513 irq_set_handler_data(bank->irq, bank);