Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/x86: pmt: Fix a potential Oops on error in probe

The "ns->attr_grp" pointer can be NULL so this error handling code needs
to check for that to avoid an Oops.

Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20201117072251.GC1111239@mwanda
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Dan Carpenter and committed by
Hans de Goede
d3d73d25 469bc41c

+2 -1
+2 -1
drivers/platform/x86/intel_pmt_class.c
··· 225 225 return 0; 226 226 227 227 fail_ioremap: 228 - sysfs_remove_group(entry->kobj, ns->attr_grp); 228 + if (ns->attr_grp) 229 + sysfs_remove_group(entry->kobj, ns->attr_grp); 229 230 fail_sysfs: 230 231 device_unregister(dev); 231 232 fail_dev_create: