Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] zalon: fix oops on attach failure

I recently discovered on my zalon that if the attachment fails because
of a bus misconfiguration (I scrapped my HVD array, so the card is now
unterminated) then the system oopses. The reason is that if
ncr_attach() returns NULL (signalling failure) that NULL is passed by
the goto failed straight into ncr_detach() which oopses.

The fix is just to return -ENODEV in this case.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

+1 -1
+1 -1
drivers/scsi/zalon.c
··· 134 134 135 135 host = ncr_attach(&zalon7xx_template, unit, &device); 136 136 if (!host) 137 - goto fail; 137 + return -ENODEV; 138 138 139 139 if (request_irq(dev->irq, ncr53c8xx_intr, IRQF_SHARED, "zalon", host)) { 140 140 dev_printk(KERN_ERR, &dev->dev, "irq problem with %d, detaching\n ",