Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dt-bindings: phy-qcom-qmp: Move #clock-cells to child

The phy-qcom-qmp bindings specified #clock-cells as 1. This was never used
because of_clk_add_provider() was never called, so there was no way anybody
could reference these clocks from DT. Furthermore, even if they could be
accessed, the bindings never specified what should go in that additional
cell.

Fix these incomplete and broken bindings. Move the #clock-cells into the
child node, since that is the actual clock provider, and not all
instances of qcom-qmp-phy are clock providers. Also set #clock-cells to
zero, since there's nothing to pass to it.

Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

authored by

Evan Green and committed by
Kishon Vijay Abraham I
d21aafe9 5e17b95d

+5 -6
+5 -6
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
··· 25 25 - For all others: 26 26 - The reg-names property shouldn't be defined. 27 27 28 - - #clock-cells: must be 1 (PCIe and USB3 PHYs only) 29 - - Phy pll outputs a bunch of clocks for Tx, Rx and Pipe 30 - interface (for pipe based PHYs). These clock are then gate-controlled 31 - by gcc. 32 28 - #address-cells: must be 1 33 29 - #size-cells: must be 1 34 30 - ranges: must be present ··· 102 106 - "pcie20_phy0_pipe_clk" Pipe Clock parent 103 107 (or) 104 108 "pcie20_phy1_pipe_clk" 109 + - #clock-cells: must be 0 110 + - Phy pll outputs pipe clocks for pipe based PHYs. These clocks are then 111 + gate-controlled by the gcc. 105 112 106 113 Required properties for child node of PHYs with lane reset, AKA: 107 114 "qcom,msm8996-qmp-pcie-phy" ··· 117 118 phy@34000 { 118 119 compatible = "qcom,msm8996-qmp-pcie-phy"; 119 120 reg = <0x34000 0x488>; 120 - #clock-cells = <1>; 121 121 #address-cells = <1>; 122 122 #size-cells = <1>; 123 123 ranges; ··· 138 140 reg = <0x35000 0x130>, 139 141 <0x35200 0x200>, 140 142 <0x35400 0x1dc>; 143 + #clock-cells = <0>; 141 144 #phy-cells = <0>; 142 145 143 146 clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; ··· 156 157 phy@88eb000 { 157 158 compatible = "qcom,sdm845-qmp-usb3-uni-phy"; 158 159 reg = <0x88eb000 0x18c>; 159 - #clock-cells = <1>; 160 160 #address-cells = <1>; 161 161 #size-cells = <1>; 162 162 ranges; ··· 175 177 <0x88eb400 0x1fc>, 176 178 <0x88eb800 0x218>, 177 179 <0x88eb600 0x70>; 180 + #clock-cells = <0>; 178 181 #phy-cells = <0>; 179 182 clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>; 180 183 clock-names = "pipe0";