Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reset: tegra-bpmp: Restore Handle errors in BPMP response

This reverts following commit 69125b4b9440 ("reset: tegra-bpmp: Revert
Handle errors in BPMP response").

The Tegra194 HDA reset failure is fixed by commit d278dc9151a0 ("ALSA:
hda/tegra: Fix Tegra194 HDA reset failure"). The temporary revert of
original commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
response") can be removed now.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/1641995806-15245-1-git-send-email-spujar@nvidia.com

authored by

Sameer Pujar and committed by
Philipp Zabel
d1da1052 da18980a

+8 -1
+8 -1
drivers/reset/tegra/reset-bpmp.c
··· 20 20 struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc); 21 21 struct mrq_reset_request request; 22 22 struct tegra_bpmp_message msg; 23 + int err; 23 24 24 25 memset(&request, 0, sizeof(request)); 25 26 request.cmd = command; ··· 31 30 msg.tx.data = &request; 32 31 msg.tx.size = sizeof(request); 33 32 34 - return tegra_bpmp_transfer(bpmp, &msg); 33 + err = tegra_bpmp_transfer(bpmp, &msg); 34 + if (err) 35 + return err; 36 + if (msg.rx.ret) 37 + return -EINVAL; 38 + 39 + return 0; 35 40 } 36 41 37 42 static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,