Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: impa7: add missing __iomem annotation

Added missing __iomem annotation and used NULL instead of 0
in order to fix the following sparse warnings:

drivers/mtd/maps/impa7.c:82:32: warning: Using plain integer as NULL pointer
drivers/mtd/maps/impa7.c:96:34: warning: cast removes address space of expression
drivers/mtd/maps/impa7.c:96:34: warning: incorrect type in argument 1 (different address spaces)
drivers/mtd/maps/impa7.c:96:34: expected void volatile [noderef] <asn:2>*addr
drivers/mtd/maps/impa7.c:96:34: got void *<noident>
drivers/mtd/maps/impa7.c:108:34: warning: cast removes address space of expression
drivers/mtd/maps/impa7.c:108:34: warning: incorrect type in argument 1 (different address spaces)
drivers/mtd/maps/impa7.c:108:34: expected void volatile [noderef] <asn:2>*addr
drivers/mtd/maps/impa7.c:108:34: got void *<noident>
drivers/mtd/maps/impa7.c:109:45: warning: Using plain integer as NULL pointer

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

authored by

Jingoo Han and committed by
David Woodhouse
d1d90c99 582b2ffc

+5 -5
+5 -5
drivers/mtd/maps/impa7.c
··· 79 79 } 80 80 simple_map_init(&impa7_map[i]); 81 81 82 - impa7_mtd[i] = 0; 82 + impa7_mtd[i] = NULL; 83 83 type = rom_probe_types; 84 84 for(; !impa7_mtd[i] && *type; type++) { 85 85 impa7_mtd[i] = do_map_probe(*type, &impa7_map[i]); ··· 91 91 mtd_device_parse_register(impa7_mtd[i], NULL, NULL, 92 92 partitions, 93 93 ARRAY_SIZE(partitions)); 94 + } else { 95 + iounmap((void __iomem *)impa7_map[i].virt); 94 96 } 95 - else 96 - iounmap((void *)impa7_map[i].virt); 97 97 } 98 98 return devicesfound == 0 ? -ENXIO : 0; 99 99 } ··· 105 105 if (impa7_mtd[i]) { 106 106 mtd_device_unregister(impa7_mtd[i]); 107 107 map_destroy(impa7_mtd[i]); 108 - iounmap((void *)impa7_map[i].virt); 109 - impa7_map[i].virt = 0; 108 + iounmap((void __iomem *)impa7_map[i].virt); 109 + impa7_map[i].virt = NULL; 110 110 } 111 111 } 112 112 }