[ARM] Off-by-one in arch/arm/common/icst*

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

hi,

a quick find -iname \*.[ch] | xargs grep "> ARRAY_SIZE(", revealed
these in the icst drivers.
If i == ARRAY_SIZE, we get past the idx2s array.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

authored by

Eric Sesterhenn and committed by

Russell King 19 years ago d1d8f7de 576b3ef2

+4 -4

2 changed files

expand all

arch

arm

common

icst307.c

icst525.c

+2 -2

arch/arm/common/icst307.c

··· 57 57 break; 58 58 } while (i < ARRAY_SIZE(idx2s)); 59 59 60 - if (i > ARRAY_SIZE(idx2s)) 60 + if (i >= ARRAY_SIZE(idx2s)) 61 61 return vco; 62 62 63 63 vco.s = idx2s[i]; ··· 119 119 break; 120 120 } while (i < ARRAY_SIZE(idx2s)); 121 121 122 - if (i > ARRAY_SIZE(idx2s)) 122 + if (i >= ARRAY_SIZE(idx2s)) 123 123 return vco; 124 124 125 125 vco.s = idx2s[i];

+2 -2

arch/arm/common/icst525.c

··· 55 55 break; 56 56 } while (i < ARRAY_SIZE(idx2s)); 57 57 58 - if (i > ARRAY_SIZE(idx2s)) 58 + if (i >= ARRAY_SIZE(idx2s)) 59 59 return vco; 60 60 61 61 vco.s = idx2s[i]; ··· 118 118 break; 119 119 } while (i < ARRAY_SIZE(idx2s)); 120 120 121 - if (i > ARRAY_SIZE(idx2s)) 121 + if (i >= ARRAY_SIZE(idx2s)) 122 122 return vco; 123 123 124 124 vco.s = idx2s[i];