Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[POWERPC] fix up front-LED Kconfig

This patch fixes the front-LED Kconfig issues I introduced while
creating it. Apparently having a dependency isn't enough to have the
select not evaluated or something like that.

The patch also changes the default configuration for pmac32 select the
default for the LED to be the IDE trigger. While I was at it, I
completely updated the defconfig and also added snd-aoa to it.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>

authored by

Johannes Berg and committed by
Paul Mackerras
d1a8df91 b4e54de8

+106 -31
+96 -16
arch/powerpc/configs/pmac32_defconfig
··· 1 1 # 2 2 # Automatically generated make config: don't edit 3 - # Linux kernel version: 2.6.17-rc5 4 - # Mon May 29 14:47:49 2006 3 + # Linux kernel version: 2.6.17 4 + # Mon Jul 3 14:20:49 2006 5 5 # 6 6 # CONFIG_PPC64 is not set 7 7 CONFIG_PPC32=y 8 8 CONFIG_PPC_MERGE=y 9 9 CONFIG_MMU=y 10 10 CONFIG_GENERIC_HARDIRQS=y 11 + CONFIG_IRQ_PER_CPU=y 11 12 CONFIG_RWSEM_XCHGADD_ALGORITHM=y 12 13 CONFIG_GENERIC_HWEIGHT=y 13 14 CONFIG_GENERIC_CALIBRATE_DELAY=y 15 + CONFIG_GENERIC_FIND_NEXT_BIT=y 14 16 CONFIG_PPC=y 15 17 CONFIG_EARLY_PRINTK=y 16 18 CONFIG_GENERIC_NVRAM=y ··· 31 29 # CONFIG_PPC_82xx is not set 32 30 # CONFIG_PPC_83xx is not set 33 31 # CONFIG_PPC_85xx is not set 32 + # CONFIG_PPC_86xx is not set 34 33 # CONFIG_40x is not set 35 34 # CONFIG_44x is not set 36 35 # CONFIG_8xx is not set ··· 42 39 CONFIG_PPC_STD_MMU=y 43 40 CONFIG_PPC_STD_MMU_32=y 44 41 # CONFIG_SMP is not set 42 + CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" 45 43 46 44 # 47 45 # Code maturity level options ··· 76 72 CONFIG_BUG=y 77 73 CONFIG_ELF_CORE=y 78 74 CONFIG_BASE_FULL=y 75 + CONFIG_RT_MUTEXES=y 79 76 CONFIG_FUTEX=y 80 77 CONFIG_EPOLL=y 81 78 CONFIG_SHMEM=y 82 79 CONFIG_SLAB=y 80 + CONFIG_VM_EVENT_COUNTERS=y 83 81 # CONFIG_TINY_SHMEM is not set 84 82 CONFIG_BASE_SMALL=0 85 83 # CONFIG_SLOB is not set ··· 125 119 # CONFIG_APUS is not set 126 120 # CONFIG_PPC_CHRP is not set 127 121 CONFIG_PPC_PMAC=y 122 + # CONFIG_PPC_CELL is not set 123 + # CONFIG_PPC_CELL_NATIVE is not set 124 + # CONFIG_UDBG_RTAS_CONSOLE is not set 128 125 CONFIG_MPIC=y 129 126 # CONFIG_PPC_RTAS is not set 130 127 # CONFIG_MMIO_NVRAM is not set ··· 163 154 # CONFIG_PREEMPT is not set 164 155 CONFIG_BINFMT_ELF=y 165 156 CONFIG_BINFMT_MISC=m 157 + CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y 166 158 # CONFIG_KEXEC is not set 167 159 CONFIG_ARCH_FLATMEM_ENABLE=y 168 160 CONFIG_SELECT_MEMORY_MODEL=y ··· 174 164 CONFIG_FLAT_NODE_MEM_MAP=y 175 165 # CONFIG_SPARSEMEM_STATIC is not set 176 166 CONFIG_SPLIT_PTLOCK_CPUS=4 167 + # CONFIG_RESOURCES_64BIT is not set 177 168 CONFIG_PROC_DEVICETREE=y 178 169 # CONFIG_CMDLINE_BOOL is not set 179 170 CONFIG_PM=y ··· 193 182 CONFIG_PPC_INDIRECT_PCI=y 194 183 CONFIG_PCI=y 195 184 CONFIG_PCI_DOMAINS=y 185 + # CONFIG_PCIEPORTBUS is not set 196 186 # CONFIG_PCI_DEBUG is not set 197 187 198 188 # ··· 268 256 # CONFIG_INET_IPCOMP is not set 269 257 # CONFIG_INET_XFRM_TUNNEL is not set 270 258 # CONFIG_INET_TUNNEL is not set 259 + # CONFIG_INET_XFRM_MODE_TRANSPORT is not set 260 + # CONFIG_INET_XFRM_MODE_TUNNEL is not set 271 261 CONFIG_INET_DIAG=y 272 262 CONFIG_INET_TCP_DIAG=y 273 263 # CONFIG_TCP_CONG_ADVANCED is not set ··· 282 268 # CONFIG_IPV6 is not set 283 269 # CONFIG_INET6_XFRM_TUNNEL is not set 284 270 # CONFIG_INET6_TUNNEL is not set 271 + # CONFIG_NETWORK_SECMARK is not set 285 272 CONFIG_NETFILTER=y 286 273 # CONFIG_NETFILTER_DEBUG is not set 287 274 ··· 307 292 CONFIG_NETFILTER_XT_MATCH_POLICY=m 308 293 CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m 309 294 CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m 295 + # CONFIG_NETFILTER_XT_MATCH_QUOTA is not set 310 296 CONFIG_NETFILTER_XT_MATCH_REALM=m 311 297 CONFIG_NETFILTER_XT_MATCH_SCTP=m 312 298 CONFIG_NETFILTER_XT_MATCH_STATE=m 299 + # CONFIG_NETFILTER_XT_MATCH_STATISTIC is not set 313 300 CONFIG_NETFILTER_XT_MATCH_STRING=m 314 301 CONFIG_NETFILTER_XT_MATCH_TCPMSS=m 315 302 ··· 330 313 CONFIG_IP_NF_AMANDA=m 331 314 CONFIG_IP_NF_PPTP=m 332 315 CONFIG_IP_NF_H323=m 316 + # CONFIG_IP_NF_SIP is not set 333 317 # CONFIG_IP_NF_QUEUE is not set 334 318 CONFIG_IP_NF_IPTABLES=m 335 319 CONFIG_IP_NF_MATCH_IPRANGE=m ··· 475 457 # CONFIG_ALI_FIR is not set 476 458 # CONFIG_VLSI_FIR is not set 477 459 # CONFIG_VIA_FIR is not set 460 + # CONFIG_MCS_FIR is not set 478 461 CONFIG_BT=m 479 462 CONFIG_BT_L2CAP=m 480 463 CONFIG_BT_SCO=m ··· 519 500 CONFIG_PREVENT_FIRMWARE_BUILD=y 520 501 CONFIG_FW_LOADER=y 521 502 # CONFIG_DEBUG_DRIVER is not set 503 + # CONFIG_SYS_HYPERVISOR is not set 522 504 523 505 # 524 506 # Connector - unified userspace <-> kernelspace linker ··· 620 600 CONFIG_BLK_DEV_IDE_PMAC=y 621 601 CONFIG_BLK_DEV_IDE_PMAC_ATA100FIRST=y 622 602 CONFIG_BLK_DEV_IDEDMA_PMAC=y 623 - CONFIG_BLK_DEV_IDE_PMAC_BLINK=y 624 603 # CONFIG_IDE_ARM is not set 625 604 CONFIG_BLK_DEV_IDEDMA=y 626 605 # CONFIG_IDEDMA_IVB is not set ··· 680 661 # CONFIG_MEGARAID_LEGACY is not set 681 662 # CONFIG_MEGARAID_SAS is not set 682 663 # CONFIG_SCSI_SATA is not set 664 + # CONFIG_SCSI_HPTIOP is not set 683 665 # CONFIG_SCSI_BUSLOGIC is not set 684 666 # CONFIG_SCSI_DMX3191D is not set 685 667 # CONFIG_SCSI_EATA is not set ··· 725 705 CONFIG_MD_RAID0=m 726 706 CONFIG_MD_RAID1=m 727 707 CONFIG_MD_RAID10=m 728 - CONFIG_MD_RAID5=m 729 - CONFIG_MD_RAID5_RESHAPE=y 730 - CONFIG_MD_RAID6=m 708 + # CONFIG_MD_RAID456 is not set 731 709 CONFIG_MD_MULTIPATH=m 732 710 CONFIG_MD_FAULTY=m 733 711 CONFIG_BLK_DEV_DM=m ··· 768 750 # 769 751 CONFIG_IEEE1394_VIDEO1394=m 770 752 CONFIG_IEEE1394_SBP2=m 771 - # CONFIG_IEEE1394_SBP2_PHYS_DMA is not set 772 753 # CONFIG_IEEE1394_ETH1394 is not set 773 754 CONFIG_IEEE1394_DV1394=m 774 755 CONFIG_IEEE1394_RAWIO=m ··· 783 766 CONFIG_ADB=y 784 767 CONFIG_ADB_CUDA=y 785 768 CONFIG_ADB_PMU=y 769 + CONFIG_ADB_PMU_LED=y 770 + CONFIG_ADB_PMU_LED_IDE=y 786 771 CONFIG_PMAC_APM_EMU=m 787 772 CONFIG_PMAC_MEDIABAY=y 788 773 CONFIG_PMAC_BACKLIGHT=y 774 + CONFIG_PMAC_BACKLIGHT_LEGACY=y 789 775 CONFIG_INPUT_ADBHID=y 790 776 CONFIG_MAC_EMUMOUSEBTN=y 791 777 CONFIG_THERM_WINDTUNNEL=m ··· 878 858 # CONFIG_CHELSIO_T1 is not set 879 859 # CONFIG_IXGB is not set 880 860 # CONFIG_S2IO is not set 861 + # CONFIG_MYRI10GE is not set 881 862 882 863 # 883 864 # Token Ring devices ··· 929 908 # Prism GT/Duette 802.11(a/b/g) PCI/Cardbus support 930 909 # 931 910 CONFIG_PRISM54=m 911 + # CONFIG_USB_ZD1201 is not set 932 912 # CONFIG_HOSTAP is not set 933 913 CONFIG_NET_WIRELESS=y 934 914 ··· 1020 998 CONFIG_VT=y 1021 999 CONFIG_VT_CONSOLE=y 1022 1000 CONFIG_HW_CONSOLE=y 1001 + # CONFIG_VT_HW_CONSOLE_BINDING is not set 1023 1002 # CONFIG_SERIAL_NONSTANDARD is not set 1024 1003 1025 1004 # ··· 1052 1029 # Watchdog Cards 1053 1030 # 1054 1031 # CONFIG_WATCHDOG is not set 1032 + # CONFIG_HW_RANDOM is not set 1055 1033 CONFIG_NVRAM=y 1056 1034 CONFIG_GEN_RTC=y 1057 1035 # CONFIG_GEN_RTC_X is not set ··· 1064 1040 # Ftape, the floppy tape device driver 1065 1041 # 1066 1042 CONFIG_AGP=m 1043 + # CONFIG_AGP_SIS is not set 1067 1044 # CONFIG_AGP_VIA is not set 1068 1045 CONFIG_AGP_UNINORTH=m 1069 1046 CONFIG_DRM=m ··· 1117 1092 CONFIG_I2C_POWERMAC=y 1118 1093 # CONFIG_I2C_MPC is not set 1119 1094 # CONFIG_I2C_NFORCE2 is not set 1095 + # CONFIG_I2C_OCORES is not set 1120 1096 # CONFIG_I2C_PARPORT_LIGHT is not set 1121 1097 # CONFIG_I2C_PROSAVAGE is not set 1122 1098 # CONFIG_I2C_SAVAGE4 is not set ··· 1182 1156 # 1183 1157 # Graphics support 1184 1158 # 1159 + # CONFIG_FIRMWARE_EDID is not set 1185 1160 CONFIG_FB=y 1186 1161 CONFIG_FB_CFB_FILLRECT=y 1187 1162 CONFIG_FB_CFB_COPYAREA=y 1188 1163 CONFIG_FB_CFB_IMAGEBLIT=y 1189 1164 CONFIG_FB_MACMODES=y 1190 - CONFIG_FB_FIRMWARE_EDID=y 1165 + CONFIG_FB_BACKLIGHT=y 1191 1166 CONFIG_FB_MODE_HELPERS=y 1192 1167 CONFIG_FB_TILEBLITTING=y 1193 1168 # CONFIG_FB_CIRRUS is not set ··· 1205 1178 # CONFIG_FB_S1D13XXX is not set 1206 1179 CONFIG_FB_NVIDIA=y 1207 1180 CONFIG_FB_NVIDIA_I2C=y 1181 + CONFIG_FB_NVIDIA_BACKLIGHT=y 1208 1182 # CONFIG_FB_RIVA is not set 1209 1183 CONFIG_FB_MATROX=y 1210 1184 CONFIG_FB_MATROX_MILLENIUM=y ··· 1215 1187 # CONFIG_FB_MATROX_MULTIHEAD is not set 1216 1188 CONFIG_FB_RADEON=y 1217 1189 CONFIG_FB_RADEON_I2C=y 1190 + CONFIG_FB_RADEON_BACKLIGHT=y 1218 1191 # CONFIG_FB_RADEON_DEBUG is not set 1219 1192 CONFIG_FB_ATY128=y 1193 + CONFIG_FB_ATY128_BACKLIGHT=y 1220 1194 CONFIG_FB_ATY=y 1221 1195 CONFIG_FB_ATY_CT=y 1222 1196 # CONFIG_FB_ATY_GENERIC_LCD is not set 1223 1197 CONFIG_FB_ATY_GX=y 1198 + CONFIG_FB_ATY_BACKLIGHT=y 1224 1199 # CONFIG_FB_SAVAGE is not set 1225 1200 # CONFIG_FB_SIS is not set 1226 1201 # CONFIG_FB_NEOMAGIC is not set ··· 1252 1221 CONFIG_LOGO_LINUX_MONO=y 1253 1222 CONFIG_LOGO_LINUX_VGA16=y 1254 1223 CONFIG_LOGO_LINUX_CLUT224=y 1255 - # CONFIG_BACKLIGHT_LCD_SUPPORT is not set 1224 + CONFIG_BACKLIGHT_LCD_SUPPORT=y 1225 + CONFIG_BACKLIGHT_CLASS_DEVICE=y 1226 + CONFIG_BACKLIGHT_DEVICE=y 1227 + CONFIG_LCD_CLASS_DEVICE=m 1228 + CONFIG_LCD_DEVICE=y 1256 1229 1257 1230 # 1258 1231 # Sound ··· 1313 1278 # CONFIG_SND_CMIPCI is not set 1314 1279 # CONFIG_SND_CS4281 is not set 1315 1280 # CONFIG_SND_CS46XX is not set 1281 + # CONFIG_SND_DARLA20 is not set 1282 + # CONFIG_SND_GINA20 is not set 1283 + # CONFIG_SND_LAYLA20 is not set 1284 + # CONFIG_SND_DARLA24 is not set 1285 + # CONFIG_SND_GINA24 is not set 1286 + # CONFIG_SND_LAYLA24 is not set 1287 + # CONFIG_SND_MONA is not set 1288 + # CONFIG_SND_MIA is not set 1289 + # CONFIG_SND_ECHO3G is not set 1290 + # CONFIG_SND_INDIGO is not set 1291 + # CONFIG_SND_INDIGOIO is not set 1292 + # CONFIG_SND_INDIGODJ is not set 1316 1293 # CONFIG_SND_EMU10K1 is not set 1317 1294 # CONFIG_SND_EMU10K1X is not set 1318 1295 # CONFIG_SND_ENS1370 is not set ··· 1360 1313 # 1361 1314 CONFIG_SND_POWERMAC=m 1362 1315 CONFIG_SND_POWERMAC_AUTO_DRC=y 1316 + 1317 + # 1318 + # Apple Onboard Audio driver 1319 + # 1320 + CONFIG_SND_AOA=m 1321 + CONFIG_SND_AOA_FABRIC_LAYOUT=m 1322 + CONFIG_SND_AOA_ONYX=m 1323 + CONFIG_SND_AOA_TAS=m 1324 + CONFIG_SND_AOA_TOONIE=m 1325 + CONFIG_SND_AOA_SOUNDBUS=m 1326 + CONFIG_SND_AOA_SOUNDBUS_I2S=m 1363 1327 1364 1328 # 1365 1329 # USB devices ··· 1413 1355 CONFIG_USB_EHCI_HCD=m 1414 1356 CONFIG_USB_EHCI_SPLIT_ISO=y 1415 1357 CONFIG_USB_EHCI_ROOT_HUB_TT=y 1358 + # CONFIG_USB_EHCI_TT_NEWSCHED is not set 1416 1359 # CONFIG_USB_ISP116X_HCD is not set 1417 1360 CONFIG_USB_OHCI_HCD=y 1418 1361 # CONFIG_USB_OHCI_BIG_ENDIAN is not set ··· 1490 1431 # CONFIG_USB_NET_RNDIS_HOST is not set 1491 1432 # CONFIG_USB_NET_CDC_SUBSET is not set 1492 1433 CONFIG_USB_NET_ZAURUS=m 1493 - # CONFIG_USB_ZD1201 is not set 1494 1434 CONFIG_USB_MON=y 1495 1435 1496 1436 # ··· 1557 1499 # CONFIG_USB_LEGOTOWER is not set 1558 1500 # CONFIG_USB_LCD is not set 1559 1501 # CONFIG_USB_LED is not set 1502 + # CONFIG_USB_CY7C63 is not set 1560 1503 # CONFIG_USB_CYTHERM is not set 1561 1504 # CONFIG_USB_PHIDGETKIT is not set 1562 1505 # CONFIG_USB_PHIDGETSERVO is not set 1563 1506 # CONFIG_USB_IDMOUSE is not set 1507 + CONFIG_USB_APPLEDISPLAY=m 1564 1508 # CONFIG_USB_SISUSBVGA is not set 1565 1509 # CONFIG_USB_LD is not set 1566 1510 # CONFIG_USB_TEST is not set ··· 1584 1524 # 1585 1525 # LED devices 1586 1526 # 1587 - # CONFIG_NEW_LEDS is not set 1527 + CONFIG_NEW_LEDS=y 1528 + CONFIG_LEDS_CLASS=y 1588 1529 1589 1530 # 1590 1531 # LED drivers ··· 1594 1533 # 1595 1534 # LED Triggers 1596 1535 # 1536 + CONFIG_LEDS_TRIGGERS=y 1537 + # CONFIG_LEDS_TRIGGER_TIMER is not set 1538 + CONFIG_LEDS_TRIGGER_IDE_DISK=y 1539 + # CONFIG_LEDS_TRIGGER_HEARTBEAT is not set 1597 1540 1598 1541 # 1599 1542 # InfiniBand support ··· 1612 1547 # Real Time Clock 1613 1548 # 1614 1549 # CONFIG_RTC_CLASS is not set 1550 + 1551 + # 1552 + # DMA Engine support 1553 + # 1554 + # CONFIG_DMA_ENGINE is not set 1555 + 1556 + # 1557 + # DMA Clients 1558 + # 1559 + 1560 + # 1561 + # DMA Devices 1562 + # 1615 1563 1616 1564 # 1617 1565 # File systems ··· 1647 1569 # CONFIG_MINIX_FS is not set 1648 1570 # CONFIG_ROMFS_FS is not set 1649 1571 CONFIG_INOTIFY=y 1572 + CONFIG_INOTIFY_USER=y 1650 1573 # CONFIG_QUOTA is not set 1651 1574 CONFIG_DNOTIFY=y 1652 1575 # CONFIG_AUTOFS_FS is not set ··· 1728 1649 CONFIG_SMB_FS=m 1729 1650 # CONFIG_SMB_NLS_DEFAULT is not set 1730 1651 # CONFIG_CIFS is not set 1652 + # CONFIG_CIFS_DEBUG2 is not set 1731 1653 # CONFIG_NCP_FS is not set 1732 1654 # CONFIG_CODA_FS is not set 1733 1655 # CONFIG_AFS_FS is not set ··· 1812 1732 CONFIG_TEXTSEARCH_KMP=m 1813 1733 CONFIG_TEXTSEARCH_BM=m 1814 1734 CONFIG_TEXTSEARCH_FSM=m 1735 + CONFIG_PLIST=y 1815 1736 1816 1737 # 1817 1738 # Instrumentation Support ··· 1825 1744 # 1826 1745 # CONFIG_PRINTK_TIME is not set 1827 1746 # CONFIG_MAGIC_SYSRQ is not set 1747 + # CONFIG_UNUSED_SYMBOLS is not set 1828 1748 CONFIG_DEBUG_KERNEL=y 1829 1749 CONFIG_LOG_BUF_SHIFT=14 1830 1750 CONFIG_DETECT_SOFTLOCKUP=y 1831 1751 # CONFIG_SCHEDSTATS is not set 1832 1752 # CONFIG_DEBUG_SLAB is not set 1833 1753 # CONFIG_DEBUG_MUTEXES is not set 1754 + # CONFIG_DEBUG_RT_MUTEXES is not set 1755 + # CONFIG_RT_MUTEX_TESTER is not set 1834 1756 # CONFIG_DEBUG_SPINLOCK is not set 1835 1757 # CONFIG_DEBUG_SPINLOCK_SLEEP is not set 1836 1758 # CONFIG_DEBUG_KOBJECT is not set ··· 1847 1763 CONFIG_XMON_DEFAULT=y 1848 1764 # CONFIG_BDI_SWITCH is not set 1849 1765 CONFIG_BOOTX_TEXT=y 1850 - # CONFIG_PPC_EARLY_DEBUG_LPAR is not set 1851 - # CONFIG_PPC_EARLY_DEBUG_G5 is not set 1852 - # CONFIG_PPC_EARLY_DEBUG_RTAS is not set 1853 - # CONFIG_PPC_EARLY_DEBUG_MAPLE is not set 1854 - # CONFIG_PPC_EARLY_DEBUG_ISERIES is not set 1766 + # CONFIG_PPC_EARLY_DEBUG is not set 1855 1767 1856 1768 # 1857 1769 # Security options
-14
drivers/ide/Kconfig
··· 773 773 to transfer data to and from memory. Saying Y is safe and improves 774 774 performance. 775 775 776 - config BLK_DEV_IDE_PMAC_BLINK 777 - bool "Blink laptop LED on drive activity (DEPRECATED)" 778 - depends on BLK_DEV_IDE_PMAC && ADB_PMU 779 - select ADB_PMU_LED 780 - select LEDS_TRIGGERS 781 - select LEDS_TRIGGER_IDE_DISK 782 - help 783 - This option enables the use of the sleep LED as a hard drive 784 - activity LED. 785 - This option is deprecated, it only selects ADB_PMU_LED and 786 - LEDS_TRIGGER_IDE_DISK and changes the code in the new led class 787 - device to default to the ide-disk trigger (which should be set 788 - from userspace via sysfs). 789 - 790 776 config BLK_DEV_IDE_SWARM 791 777 tristate "IDE for Sibyte evaluation boards" 792 778 depends on SIBYTE_SB1xxx_SOC
+9
drivers/macintosh/Kconfig
··· 90 90 and the ide-disk LED trigger and configure appropriately through 91 91 sysfs. 92 92 93 + config ADB_PMU_LED_IDE 94 + bool "Use front LED as IDE LED by default" 95 + depends on ADB_PMU_LED 96 + select LEDS_TRIGGERS 97 + select LEDS_TRIGGER_IDE_DISK 98 + help 99 + This option makes the front LED default to the IDE trigger 100 + so that it blinks on IDE activity. 101 + 93 102 config PMAC_SMU 94 103 bool "Support for SMU based PowerMacs" 95 104 depends on PPC_PMAC64
+1 -1
drivers/macintosh/via-pmu-led.c
··· 74 74 75 75 static struct led_classdev pmu_led = { 76 76 .name = "pmu-front-led", 77 - #ifdef CONFIG_BLK_DEV_IDE_PMAC_BLINK 77 + #ifdef CONFIG_ADB_PMU_LED_IDE 78 78 .default_trigger = "ide-disk", 79 79 #endif 80 80 .brightness_set = pmu_led_set,