Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: gamecube: Check the return value of ioremap()

The function ioremap() in gamecube_rtc_read_offset_from_sram() can fail
and return NULL, which is dereferenced without checking, leading to a
NULL pointer dereference.

Add a check for the return value of ioremap() and return -ENOMEM on
failure.

Fixes: 86559400b3ef ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Link Mauve <kernel@linkmauve.fr>
Link: https://patch.msgid.link/20251126080625.1752-1-vulab@iscas.ac.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Haotian Zhang and committed by
Alexandre Belloni
d1220e47 22a6db42

+4
+4
drivers/rtc/rtc-gamecube.c
··· 242 242 } 243 243 244 244 hw_srnprot = ioremap(res.start, resource_size(&res)); 245 + if (!hw_srnprot) { 246 + pr_err("failed to ioremap hw_srnprot\n"); 247 + return -ENOMEM; 248 + } 245 249 old = ioread32be(hw_srnprot); 246 250 247 251 /* TODO: figure out why we use this magic constant. I obtained it by