Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

RDMA/hns: Modify appropriate printings

Modify some printings that is not in uniformed style, non-standard or with
spelling errors.

Link: https://lore.kernel.org/r/1572952082-6681-10-git-send-email-liweihang@hisilicon.com
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Weihang Li <liweihang@hisilicon.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

authored by

Wenpeng Liang and committed by
Jason Gunthorpe
d11769fd 1ceb0b11

+19 -15
+12 -8
drivers/infiniband/hw/hns/hns_roce_cq.c
··· 105 105 mtts = hns_roce_table_find(hr_dev, mtt_table, 106 106 hr_mtt->first_seg, &dma_handle); 107 107 if (!mtts) { 108 - dev_err(dev, "CQ alloc.Failed to find cq buf addr.\n"); 108 + dev_err(dev, "Failed to find mtt for CQ buf.\n"); 109 109 return -EINVAL; 110 110 } 111 111 112 112 if (vector >= hr_dev->caps.num_comp_vectors) { 113 - dev_err(dev, "CQ alloc.Invalid vector.\n"); 113 + dev_err(dev, "Invalid vector(0x%x) for CQ alloc.\n", vector); 114 114 return -EINVAL; 115 115 } 116 116 hr_cq->vector = vector; 117 117 118 118 ret = hns_roce_bitmap_alloc(&cq_table->bitmap, &hr_cq->cqn); 119 119 if (ret) { 120 - dev_err(dev, "CQ alloc.Failed to alloc index.\n"); 120 + dev_err(dev, "Num of CQ out of range.\n"); 121 121 return ret; 122 122 } 123 123 124 124 /* Get CQC memory HEM(Hardware Entry Memory) table */ 125 125 ret = hns_roce_table_get(hr_dev, &cq_table->table, hr_cq->cqn); 126 126 if (ret) { 127 - dev_err(dev, "CQ alloc.Failed to get context mem.\n"); 127 + dev_err(dev, 128 + "Get context mem failed(%d) when CQ(0x%lx) alloc.\n", 129 + ret, hr_cq->cqn); 128 130 goto err_out; 129 131 } 130 132 131 133 ret = xa_err(xa_store(&cq_table->array, hr_cq->cqn, hr_cq, GFP_KERNEL)); 132 134 if (ret) { 133 - dev_err(dev, "CQ alloc failed xa_store.\n"); 135 + dev_err(dev, "Failed to xa_store CQ.\n"); 134 136 goto err_put; 135 137 } 136 138 ··· 150 148 ret = hns_roce_hw_create_cq(hr_dev, mailbox, hr_cq->cqn); 151 149 hns_roce_free_cmd_mailbox(hr_dev, mailbox); 152 150 if (ret) { 153 - dev_err(dev, "CQ alloc.Failed to cmd mailbox.\n"); 151 + dev_err(dev, 152 + "Send cmd mailbox failed(%d) when CQ(0x%lx) alloc.\n", 153 + ret, hr_cq->cqn); 154 154 goto err_xa; 155 155 } 156 156 ··· 422 418 int ret; 423 419 424 420 if (cq_entries < 1 || cq_entries > hr_dev->caps.max_cqes) { 425 - dev_err(dev, "Creat CQ failed. entries=%d, max=%d\n", 421 + dev_err(dev, "Create CQ failed. entries=%d, max=%d\n", 426 422 cq_entries, hr_dev->caps.max_cqes); 427 423 return -EINVAL; 428 424 } ··· 452 448 ret = hns_roce_cq_alloc(hr_dev, cq_entries, &hr_cq->hr_buf.hr_mtt, 453 449 hr_cq, vector); 454 450 if (ret) { 455 - dev_err(dev, "Creat CQ .Failed to cq_alloc.\n"); 451 + dev_err(dev, "Alloc CQ failed(%d).\n", ret); 456 452 goto err_dbmap; 457 453 } 458 454
+2 -2
drivers/infiniband/hw/hns/hns_roce_main.c
··· 111 111 112 112 netdev = hr_dev->iboe.netdevs[port]; 113 113 if (!netdev) { 114 - dev_err(dev, "port(%d) can't find netdev\n", port); 114 + dev_err(dev, "Can't find netdev on port(%u)!\n", port); 115 115 return -ENODEV; 116 116 } 117 117 ··· 253 253 net_dev = hr_dev->iboe.netdevs[port]; 254 254 if (!net_dev) { 255 255 spin_unlock_irqrestore(&hr_dev->iboe.lock, flags); 256 - dev_err(dev, "find netdev %d failed!\r\n", port); 256 + dev_err(dev, "Find netdev %u failed!\n", port); 257 257 return -EINVAL; 258 258 } 259 259
+1 -1
drivers/infiniband/hw/hns/hns_roce_qp.c
··· 1031 1031 ret = hns_roce_create_qp_common(hr_dev, pd, init_attr, udata, 0, 1032 1032 hr_qp); 1033 1033 if (ret) { 1034 - ibdev_err(ibdev, "Create RC QP 0x%06lx failed(%d)\n", 1034 + ibdev_err(ibdev, "Create QP 0x%06lx failed(%d)\n", 1035 1035 hr_qp->qpn, ret); 1036 1036 kfree(hr_qp); 1037 1037 return ERR_PTR(ret);
+4 -4
drivers/infiniband/hw/hns/hns_roce_srq.c
··· 95 95 srq->mtt.first_seg, 96 96 &dma_handle_wqe); 97 97 if (!mtts_wqe) { 98 - dev_err(hr_dev->dev, 99 - "SRQ alloc.Failed to find srq buf addr.\n"); 98 + dev_err(hr_dev->dev, "Failed to find mtt for srq buf.\n"); 100 99 return -EINVAL; 101 100 } 102 101 ··· 105 106 &dma_handle_idx); 106 107 if (!mtts_idx) { 107 108 dev_err(hr_dev->dev, 108 - "SRQ alloc.Failed to find idx que buf addr.\n"); 109 + "Failed to find mtt for srq idx queue buf.\n"); 109 110 return -EINVAL; 110 111 } 111 112 112 113 ret = hns_roce_bitmap_alloc(&srq_table->bitmap, &srq->srqn); 113 114 if (ret) { 114 - dev_err(hr_dev->dev, "SRQ alloc.Failed to alloc index.\n"); 115 + dev_err(hr_dev->dev, 116 + "Failed to alloc a bit from srq bitmap.\n"); 115 117 return -ENOMEM; 116 118 } 117 119