Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

extcon: palmas: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

authored by

Krzysztof Kozlowski and committed by
Chanwoo Choi
d0f66810 ce90c3c9

+6 -12
+6 -12
drivers/extcon/extcon-palmas.c
··· 205 205 206 206 palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", 207 207 GPIOD_IN); 208 - if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) { 209 - return -EPROBE_DEFER; 210 - } else if (IS_ERR(palmas_usb->id_gpiod)) { 211 - dev_err(&pdev->dev, "failed to get id gpio\n"); 212 - return PTR_ERR(palmas_usb->id_gpiod); 213 - } 208 + if (IS_ERR(palmas_usb->id_gpiod)) 209 + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->id_gpiod), 210 + "failed to get id gpio\n"); 214 211 215 212 palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus", 216 213 GPIOD_IN); 217 - if (PTR_ERR(palmas_usb->vbus_gpiod) == -EPROBE_DEFER) { 218 - return -EPROBE_DEFER; 219 - } else if (IS_ERR(palmas_usb->vbus_gpiod)) { 220 - dev_err(&pdev->dev, "failed to get vbus gpio\n"); 221 - return PTR_ERR(palmas_usb->vbus_gpiod); 222 - } 214 + if (IS_ERR(palmas_usb->vbus_gpiod)) 215 + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->vbus_gpiod), 216 + "failed to get id gpio\n"); 223 217 224 218 if (palmas_usb->enable_id_detection && palmas_usb->id_gpiod) { 225 219 palmas_usb->enable_id_detection = false;