Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwrng: tx4939 - use devm_request_and_ioremap

Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
- \(res->name\|dev_name(dev)\|myname\))) {
- ...
- return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Julia Lawall and committed by
Herbert Xu
d0b03c5f 847cb7ef

+1 -4
+1 -4
drivers/char/hw_random/tx4939-rng.c
··· 115 115 rngdev = devm_kzalloc(&dev->dev, sizeof(*rngdev), GFP_KERNEL); 116 116 if (!rngdev) 117 117 return -ENOMEM; 118 - if (!devm_request_mem_region(&dev->dev, r->start, resource_size(r), 119 - dev_name(&dev->dev))) 120 - return -EBUSY; 121 - rngdev->base = devm_ioremap(&dev->dev, r->start, resource_size(r)); 118 + rngdev->base = devm_request_and_ioremap(&dev->dev, r); 122 119 if (!rngdev->base) 123 120 return -EBUSY; 124 121