Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends

s/drm_dp_get_validated_port_ref/drm_dp_mst_topology_get_port_validated/
s/drm_dp_put_port/drm_dp_mst_topology_put_port/
s/drm_dp_get_validated_mstb_ref/drm_dp_mst_topology_get_mstb_validated/
s/drm_dp_put_mst_branch_device/drm_dp_mst_topology_put_mstb/

This is a much more consistent naming scheme, and will make even more
sense once we redesign how the current refcounting scheme here works.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Cc: David Airlie <airlied@redhat.com>
Cc: Jerry Zuo <Jerry.Zuo@amd.com>
Cc: Juston Li <juston.li@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190111005343.17443-6-lyude@redhat.com

+62 -52
+62 -52
drivers/gpu/drm/drm_dp_mst_topology.c
··· 46 46 char *buf); 47 47 static int test_calc_pbn_mode(void); 48 48 49 - static void drm_dp_put_port(struct drm_dp_mst_port *port); 49 + static void drm_dp_mst_topology_put_port(struct drm_dp_mst_port *port); 50 50 51 51 static int drm_dp_dpcd_write_payload(struct drm_dp_mst_topology_mgr *mgr, 52 52 int id, ··· 888 888 */ 889 889 list_for_each_entry_safe(port, tmp, &mstb->ports, next) { 890 890 list_del(&port->next); 891 - drm_dp_put_port(port); 891 + drm_dp_mst_topology_put_port(port); 892 892 } 893 893 894 894 /* drop any tx slots msg */ ··· 911 911 kref_put(kref, drm_dp_free_mst_branch_device); 912 912 } 913 913 914 - static void drm_dp_put_mst_branch_device(struct drm_dp_mst_branch *mstb) 914 + static void drm_dp_mst_topology_put_mstb(struct drm_dp_mst_branch *mstb) 915 915 { 916 916 kref_put(&mstb->kref, drm_dp_destroy_mst_branch_device); 917 917 } ··· 930 930 case DP_PEER_DEVICE_MST_BRANCHING: 931 931 mstb = port->mstb; 932 932 port->mstb = NULL; 933 - drm_dp_put_mst_branch_device(mstb); 933 + drm_dp_mst_topology_put_mstb(mstb); 934 934 break; 935 935 } 936 936 } ··· 970 970 kfree(port); 971 971 } 972 972 973 - static void drm_dp_put_port(struct drm_dp_mst_port *port) 973 + static void drm_dp_mst_topology_put_port(struct drm_dp_mst_port *port) 974 974 { 975 975 kref_put(&port->kref, drm_dp_destroy_port); 976 976 } 977 977 978 - static struct drm_dp_mst_branch *drm_dp_mst_get_validated_mstb_ref_locked(struct drm_dp_mst_branch *mstb, struct drm_dp_mst_branch *to_find) 978 + static struct drm_dp_mst_branch * 979 + drm_dp_mst_topology_get_mstb_validated_locked(struct drm_dp_mst_branch *mstb, 980 + struct drm_dp_mst_branch *to_find) 979 981 { 980 982 struct drm_dp_mst_port *port; 981 983 struct drm_dp_mst_branch *rmstb; ··· 987 985 } 988 986 list_for_each_entry(port, &mstb->ports, next) { 989 987 if (port->mstb) { 990 - rmstb = drm_dp_mst_get_validated_mstb_ref_locked(port->mstb, to_find); 988 + rmstb = drm_dp_mst_topology_get_mstb_validated_locked( 989 + port->mstb, to_find); 991 990 if (rmstb) 992 991 return rmstb; 993 992 } ··· 996 993 return NULL; 997 994 } 998 995 999 - static struct drm_dp_mst_branch *drm_dp_get_validated_mstb_ref(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_branch *mstb) 996 + static struct drm_dp_mst_branch * 997 + drm_dp_mst_topology_get_mstb_validated(struct drm_dp_mst_topology_mgr *mgr, 998 + struct drm_dp_mst_branch *mstb) 1000 999 { 1001 1000 struct drm_dp_mst_branch *rmstb = NULL; 1002 1001 mutex_lock(&mgr->lock); 1003 1002 if (mgr->mst_primary) 1004 - rmstb = drm_dp_mst_get_validated_mstb_ref_locked(mgr->mst_primary, mstb); 1003 + rmstb = drm_dp_mst_topology_get_mstb_validated_locked( 1004 + mgr->mst_primary, mstb); 1005 1005 mutex_unlock(&mgr->lock); 1006 1006 return rmstb; 1007 1007 } ··· 1027 1021 return NULL; 1028 1022 } 1029 1023 1030 - static struct drm_dp_mst_port *drm_dp_get_validated_port_ref(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port) 1024 + static struct drm_dp_mst_port * 1025 + drm_dp_mst_topology_get_port_validated(struct drm_dp_mst_topology_mgr *mgr, 1026 + struct drm_dp_mst_port *port) 1031 1027 { 1032 1028 struct drm_dp_mst_port *rport = NULL; 1033 1029 mutex_lock(&mgr->lock); ··· 1223 1215 list_del(&port->next); 1224 1216 mutex_unlock(&mstb->mgr->lock); 1225 1217 /* drop port list reference */ 1226 - drm_dp_put_port(port); 1218 + drm_dp_mst_topology_put_port(port); 1227 1219 goto out; 1228 1220 } 1229 1221 if ((port->pdt == DP_PEER_DEVICE_DP_LEGACY_CONV || ··· 1238 1230 1239 1231 out: 1240 1232 /* put reference to this port */ 1241 - drm_dp_put_port(port); 1233 + drm_dp_mst_topology_put_port(port); 1242 1234 } 1243 1235 1244 1236 static void drm_dp_update_port(struct drm_dp_mst_branch *mstb, ··· 1273 1265 dowork = true; 1274 1266 } 1275 1267 1276 - drm_dp_put_port(port); 1268 + drm_dp_mst_topology_put_port(port); 1277 1269 if (dowork) 1278 1270 queue_work(system_long_wq, &mstb->mgr->work); 1279 1271 ··· 1376 1368 drm_dp_send_enum_path_resources(mgr, mstb, port); 1377 1369 1378 1370 if (port->mstb) { 1379 - mstb_child = drm_dp_get_validated_mstb_ref(mgr, port->mstb); 1371 + mstb_child = drm_dp_mst_topology_get_mstb_validated( 1372 + mgr, port->mstb); 1380 1373 if (mstb_child) { 1381 1374 drm_dp_check_and_send_link_address(mgr, mstb_child); 1382 - drm_dp_put_mst_branch_device(mstb_child); 1375 + drm_dp_mst_topology_put_mstb(mstb_child); 1383 1376 } 1384 1377 } 1385 1378 } ··· 1399 1390 mutex_unlock(&mgr->lock); 1400 1391 if (mstb) { 1401 1392 drm_dp_check_and_send_link_address(mgr, mstb); 1402 - drm_dp_put_mst_branch_device(mstb); 1393 + drm_dp_mst_topology_put_mstb(mstb); 1403 1394 } 1404 1395 } 1405 1396 ··· 1741 1732 u8 sinks[DRM_DP_MAX_SDP_STREAMS]; 1742 1733 int i; 1743 1734 1744 - port = drm_dp_get_validated_port_ref(mgr, port); 1735 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 1745 1736 if (!port) 1746 1737 return -EINVAL; 1747 1738 1748 1739 port_num = port->port_num; 1749 - mstb = drm_dp_get_validated_mstb_ref(mgr, port->parent); 1740 + mstb = drm_dp_mst_topology_get_mstb_validated(mgr, port->parent); 1750 1741 if (!mstb) { 1751 1742 mstb = drm_dp_get_last_connected_port_and_mstb(mgr, 1752 1743 port->parent, 1753 1744 &port_num); 1754 1745 1755 1746 if (!mstb) { 1756 - drm_dp_put_port(port); 1747 + drm_dp_mst_topology_put_port(port); 1757 1748 return -EINVAL; 1758 1749 } 1759 1750 } ··· 1783 1774 } 1784 1775 kfree(txmsg); 1785 1776 fail_put: 1786 - drm_dp_put_mst_branch_device(mstb); 1787 - drm_dp_put_port(port); 1777 + drm_dp_mst_topology_put_mstb(mstb); 1778 + drm_dp_mst_topology_put_port(port); 1788 1779 return ret; 1789 1780 } 1790 1781 ··· 1794 1785 struct drm_dp_sideband_msg_tx *txmsg; 1795 1786 int len, ret; 1796 1787 1797 - port = drm_dp_get_validated_port_ref(mgr, port); 1788 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 1798 1789 if (!port) 1799 1790 return -EINVAL; 1800 1791 1801 1792 txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); 1802 1793 if (!txmsg) { 1803 - drm_dp_put_port(port); 1794 + drm_dp_mst_topology_put_port(port); 1804 1795 return -ENOMEM; 1805 1796 } 1806 1797 ··· 1816 1807 ret = 0; 1817 1808 } 1818 1809 kfree(txmsg); 1819 - drm_dp_put_port(port); 1810 + drm_dp_mst_topology_put_port(port); 1820 1811 1821 1812 return ret; 1822 1813 } ··· 1905 1896 if (vcpi) { 1906 1897 port = container_of(vcpi, struct drm_dp_mst_port, 1907 1898 vcpi); 1908 - port = drm_dp_get_validated_port_ref(mgr, port); 1899 + port = drm_dp_mst_topology_get_port_validated(mgr, 1900 + port); 1909 1901 if (!port) { 1910 1902 mutex_unlock(&mgr->payload_lock); 1911 1903 return -EINVAL; ··· 1943 1933 cur_slots += req_payload.num_slots; 1944 1934 1945 1935 if (port) 1946 - drm_dp_put_port(port); 1936 + drm_dp_mst_topology_put_port(port); 1947 1937 } 1948 1938 1949 1939 for (i = 0; i < mgr->max_payloads; i++) { ··· 2042 2032 struct drm_dp_sideband_msg_tx *txmsg; 2043 2033 struct drm_dp_mst_branch *mstb; 2044 2034 2045 - mstb = drm_dp_get_validated_mstb_ref(mgr, port->parent); 2035 + mstb = drm_dp_mst_topology_get_mstb_validated(mgr, port->parent); 2046 2036 if (!mstb) 2047 2037 return -EINVAL; 2048 2038 ··· 2066 2056 } 2067 2057 kfree(txmsg); 2068 2058 fail_put: 2069 - drm_dp_put_mst_branch_device(mstb); 2059 + drm_dp_mst_topology_put_mstb(mstb); 2070 2060 return ret; 2071 2061 } 2072 2062 ··· 2210 2200 out_unlock: 2211 2201 mutex_unlock(&mgr->lock); 2212 2202 if (mstb) 2213 - drm_dp_put_mst_branch_device(mstb); 2203 + drm_dp_mst_topology_put_mstb(mstb); 2214 2204 return ret; 2215 2205 2216 2206 } ··· 2375 2365 mgr->down_rep_recv.initial_hdr.lct, 2376 2366 mgr->down_rep_recv.initial_hdr.rad[0], 2377 2367 mgr->down_rep_recv.msg[0]); 2378 - drm_dp_put_mst_branch_device(mstb); 2368 + drm_dp_mst_topology_put_mstb(mstb); 2379 2369 memset(&mgr->down_rep_recv, 0, sizeof(struct drm_dp_sideband_msg_rx)); 2380 2370 return 0; 2381 2371 } ··· 2386 2376 } 2387 2377 2388 2378 memset(&mgr->down_rep_recv, 0, sizeof(struct drm_dp_sideband_msg_rx)); 2389 - drm_dp_put_mst_branch_device(mstb); 2379 + drm_dp_mst_topology_put_mstb(mstb); 2390 2380 2391 2381 mutex_lock(&mgr->qlock); 2392 2382 txmsg->state = DRM_DP_SIDEBAND_TX_RX; ··· 2459 2449 } 2460 2450 2461 2451 if (mstb) 2462 - drm_dp_put_mst_branch_device(mstb); 2452 + drm_dp_mst_topology_put_mstb(mstb); 2463 2453 2464 2454 memset(&mgr->up_req_recv, 0, sizeof(struct drm_dp_sideband_msg_rx)); 2465 2455 } ··· 2519 2509 enum drm_connector_status status = connector_status_disconnected; 2520 2510 2521 2511 /* we need to search for the port in the mgr in case its gone */ 2522 - port = drm_dp_get_validated_port_ref(mgr, port); 2512 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2523 2513 if (!port) 2524 2514 return connector_status_disconnected; 2525 2515 ··· 2544 2534 break; 2545 2535 } 2546 2536 out: 2547 - drm_dp_put_port(port); 2537 + drm_dp_mst_topology_put_port(port); 2548 2538 return status; 2549 2539 } 2550 2540 EXPORT_SYMBOL(drm_dp_mst_detect_port); ··· 2561 2551 { 2562 2552 bool ret = false; 2563 2553 2564 - port = drm_dp_get_validated_port_ref(mgr, port); 2554 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2565 2555 if (!port) 2566 2556 return ret; 2567 2557 ret = port->has_audio; 2568 - drm_dp_put_port(port); 2558 + drm_dp_mst_topology_put_port(port); 2569 2559 return ret; 2570 2560 } 2571 2561 EXPORT_SYMBOL(drm_dp_mst_port_has_audio); ··· 2585 2575 struct edid *edid = NULL; 2586 2576 2587 2577 /* we need to search for the port in the mgr in case its gone */ 2588 - port = drm_dp_get_validated_port_ref(mgr, port); 2578 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2589 2579 if (!port) 2590 2580 return NULL; 2591 2581 ··· 2596 2586 drm_connector_set_tile_property(connector); 2597 2587 } 2598 2588 port->has_audio = drm_detect_monitor_audio(edid); 2599 - drm_dp_put_port(port); 2589 + drm_dp_mst_topology_put_port(port); 2600 2590 return edid; 2601 2591 } 2602 2592 EXPORT_SYMBOL(drm_dp_mst_get_edid); ··· 2667 2657 if (IS_ERR(topology_state)) 2668 2658 return PTR_ERR(topology_state); 2669 2659 2670 - port = drm_dp_get_validated_port_ref(mgr, port); 2660 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2671 2661 if (port == NULL) 2672 2662 return -EINVAL; 2673 2663 req_slots = DIV_ROUND_UP(pbn, mgr->pbn_div); ··· 2675 2665 req_slots, topology_state->avail_slots); 2676 2666 2677 2667 if (req_slots > topology_state->avail_slots) { 2678 - drm_dp_put_port(port); 2668 + drm_dp_mst_topology_put_port(port); 2679 2669 return -ENOSPC; 2680 2670 } 2681 2671 2682 2672 topology_state->avail_slots -= req_slots; 2683 2673 DRM_DEBUG_KMS("vcpi slots avail=%d", topology_state->avail_slots); 2684 2674 2685 - drm_dp_put_port(port); 2675 + drm_dp_mst_topology_put_port(port); 2686 2676 return req_slots; 2687 2677 } 2688 2678 EXPORT_SYMBOL(drm_dp_atomic_find_vcpi_slots); ··· 2733 2723 { 2734 2724 int ret; 2735 2725 2736 - port = drm_dp_get_validated_port_ref(mgr, port); 2726 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2737 2727 if (!port) 2738 2728 return false; 2739 2729 ··· 2744 2734 DRM_DEBUG_KMS("payload: vcpi %d already allocated for pbn %d - requested pbn %d\n", 2745 2735 port->vcpi.vcpi, port->vcpi.pbn, pbn); 2746 2736 if (pbn == port->vcpi.pbn) { 2747 - drm_dp_put_port(port); 2737 + drm_dp_mst_topology_put_port(port); 2748 2738 return true; 2749 2739 } 2750 2740 } ··· 2758 2748 DRM_DEBUG_KMS("initing vcpi for pbn=%d slots=%d\n", 2759 2749 pbn, port->vcpi.num_slots); 2760 2750 2761 - drm_dp_put_port(port); 2751 + drm_dp_mst_topology_put_port(port); 2762 2752 return true; 2763 2753 out: 2764 2754 return false; ··· 2768 2758 int drm_dp_mst_get_vcpi_slots(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port) 2769 2759 { 2770 2760 int slots = 0; 2771 - port = drm_dp_get_validated_port_ref(mgr, port); 2761 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2772 2762 if (!port) 2773 2763 return slots; 2774 2764 2775 2765 slots = port->vcpi.num_slots; 2776 - drm_dp_put_port(port); 2766 + drm_dp_mst_topology_put_port(port); 2777 2767 return slots; 2778 2768 } 2779 2769 EXPORT_SYMBOL(drm_dp_mst_get_vcpi_slots); ··· 2787 2777 */ 2788 2778 void drm_dp_mst_reset_vcpi_slots(struct drm_dp_mst_topology_mgr *mgr, struct drm_dp_mst_port *port) 2789 2779 { 2790 - port = drm_dp_get_validated_port_ref(mgr, port); 2780 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2791 2781 if (!port) 2792 2782 return; 2793 2783 port->vcpi.num_slots = 0; 2794 - drm_dp_put_port(port); 2784 + drm_dp_mst_topology_put_port(port); 2795 2785 } 2796 2786 EXPORT_SYMBOL(drm_dp_mst_reset_vcpi_slots); 2797 2787 ··· 2803 2793 void drm_dp_mst_deallocate_vcpi(struct drm_dp_mst_topology_mgr *mgr, 2804 2794 struct drm_dp_mst_port *port) 2805 2795 { 2806 - port = drm_dp_get_validated_port_ref(mgr, port); 2796 + port = drm_dp_mst_topology_get_port_validated(mgr, port); 2807 2797 if (!port) 2808 2798 return; 2809 2799 ··· 2812 2802 port->vcpi.pbn = 0; 2813 2803 port->vcpi.aligned_pbn = 0; 2814 2804 port->vcpi.vcpi = 0; 2815 - drm_dp_put_port(port); 2805 + drm_dp_mst_topology_put_port(port); 2816 2806 } 2817 2807 EXPORT_SYMBOL(drm_dp_mst_deallocate_vcpi); 2818 2808 ··· 3312 3302 struct drm_dp_sideband_msg_tx *txmsg = NULL; 3313 3303 int ret; 3314 3304 3315 - mstb = drm_dp_get_validated_mstb_ref(mgr, port->parent); 3305 + mstb = drm_dp_mst_topology_get_mstb_validated(mgr, port->parent); 3316 3306 if (!mstb) 3317 3307 return -EREMOTEIO; 3318 3308 ··· 3362 3352 } 3363 3353 out: 3364 3354 kfree(txmsg); 3365 - drm_dp_put_mst_branch_device(mstb); 3355 + drm_dp_mst_topology_put_mstb(mstb); 3366 3356 return ret; 3367 3357 } 3368 3358