Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hangcheck-timer: cleanup casting in hangcheck_init()

The 32 bit addition "(hangcheck_margin + hangcheck_tick)" could
potentially overflow. It triggers a static checker warning to have an
overflowed addition followed by a no-op cast. I have moved the cast so
that the addition can't overflow.

Also I removed the unneeded cast on the following line since both
"hangcheck_tsc_margin" and "TIMER_FREQ" are already 64 bit types.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Dan Carpenter and committed by
Greg Kroah-Hartman
d0439a54 d2522152

+2 -2
+2 -2
drivers/char/hangcheck-timer.c
··· 168 168 printk("Hangcheck: starting hangcheck timer %s (tick is %d seconds, margin is %d seconds).\n", 169 169 VERSION_STR, hangcheck_tick, hangcheck_margin); 170 170 hangcheck_tsc_margin = 171 - (unsigned long long)(hangcheck_margin + hangcheck_tick); 172 - hangcheck_tsc_margin *= (unsigned long long)TIMER_FREQ; 171 + (unsigned long long)hangcheck_margin + hangcheck_tick; 172 + hangcheck_tsc_margin *= TIMER_FREQ; 173 173 174 174 hangcheck_tsc = ktime_get_ns(); 175 175 mod_timer(&hangcheck_ticktock, jiffies + (hangcheck_tick*HZ));