Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

slimbus: core: do not call device_status under a lock

Calling device_status callback under a lock would prevent drivers
to do any slimbus trasactions which would invoke this lock like
get_laddr(). Remove this unnecessary lock!

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Srinivas Kandagatla and committed by
Greg Kroah-Hartman
cfb32101 8631f940

+3
+3
drivers/slimbus/core.c
··· 466 466 467 467 sbdev->laddr = laddr; 468 468 sbdev->is_laddr_valid = true; 469 + mutex_unlock(&ctrl->lock); 469 470 470 471 slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); 471 472 472 473 dev_dbg(ctrl->dev, "setting slimbus l-addr:%x, ea:%x,%x,%x,%x\n", 473 474 laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code, 474 475 sbdev->e_addr.dev_index, sbdev->e_addr.instance); 476 + 477 + return 0; 475 478 476 479 err: 477 480 mutex_unlock(&ctrl->lock);