Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: nand: lpc32xx: fix invalid error handling of a requested irq

Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
disabled or enabled, in the latter case IRQs are allocated starting
at least from the value specified by NR_IRQS and going upwards, so
the check of (irq >= NR_IRQ) to decide about an error code returned by
platform_get_irq() is completely invalid, don't attempt to overrule
irq subsystem in the driver.

The change fixes LPC32xx NAND MLC driver initialization on boot.

Fixes: 8cb17b5ed017 ("irqchip: Add LPC32xx interrupt controller driver")
Cc: stable@kernel.org # v4.7+
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

authored by

Vladimir Zapolskiy and committed by
Boris Brezillon
cf9e1672 8043d25b

+1 -1
+1 -1
drivers/mtd/nand/lpc32xx_mlc.c
··· 775 775 init_completion(&host->comp_controller); 776 776 777 777 host->irq = platform_get_irq(pdev, 0); 778 - if ((host->irq < 0) || (host->irq >= NR_IRQS)) { 778 + if (host->irq < 0) { 779 779 dev_err(&pdev->dev, "failed to get platform irq\n"); 780 780 res = -EINVAL; 781 781 goto err_exit3;