Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: baytrail: Unify messages with help of dev_err_probe()

Unify error messages that might appear during probe phase by
switching to use dev_err_probe().

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

+8 -12
+8 -12
drivers/pinctrl/intel/pinctrl-baytrail.c
··· 1498 1498 1499 1499 ret = gpiochip_add_pin_range(chip, dev_name(dev), 0, 0, vg->soc->npins); 1500 1500 if (ret) 1501 - dev_err(dev, "failed to add GPIO pin range\n"); 1501 + return dev_err_probe(dev, ret, "failed to add GPIO pin range\n"); 1502 1502 1503 - return ret; 1503 + return 0; 1504 1504 } 1505 1505 1506 1506 static int byt_gpio_probe(struct intel_pinctrl *vg) ··· 1548 1548 1549 1549 ret = devm_gpiochip_add_data(vg->dev, gc, vg); 1550 1550 if (ret) 1551 - dev_err(vg->dev, "failed adding byt-gpio chip\n"); 1551 + return dev_err_probe(vg->dev, ret, "failed to register gpiochip\n"); 1552 1552 1553 - return ret; 1553 + return 0; 1554 1554 } 1555 1555 1556 1556 static int byt_set_soc_data(struct intel_pinctrl *vg, ··· 1601 1601 1602 1602 vg->dev = dev; 1603 1603 ret = byt_set_soc_data(vg, soc_data); 1604 - if (ret) { 1605 - dev_err(dev, "failed to set soc data\n"); 1606 - return ret; 1607 - } 1604 + if (ret) 1605 + return dev_err_probe(dev, ret, "failed to set soc data\n"); 1608 1606 1609 1607 vg->pctldesc = byt_pinctrl_desc; 1610 1608 vg->pctldesc.name = dev_name(dev); ··· 1610 1612 vg->pctldesc.npins = vg->soc->npins; 1611 1613 1612 1614 vg->pctldev = devm_pinctrl_register(dev, &vg->pctldesc, vg); 1613 - if (IS_ERR(vg->pctldev)) { 1614 - dev_err(dev, "failed to register pinctrl driver\n"); 1615 - return PTR_ERR(vg->pctldev); 1616 - } 1615 + if (IS_ERR(vg->pctldev)) 1616 + return dev_err_probe(dev, PTR_ERR(vg->pctldev), "failed to register pinctrl\n"); 1617 1617 1618 1618 ret = byt_gpio_probe(vg); 1619 1619 if (ret)