Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lm3692x: Return 0 from remove callback

The only difference between returning zero or a non-zero value is that
for the non-zero case the i2c will print a generic error message
("remove failed (-ESOMETHING), will be ignored").

In this case however the driver itself already emitted a more helpful
error message, so the additional error message isn't helpful at all.

The long-term goal is to make the i2c remove callback return void, making
all implementations return 0 is preparatory work for this change.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>

authored by

Uwe Kleine-König and committed by
Pavel Machek
cf642fae 77d62fcc

+1 -4
+1 -4
drivers/leds/leds-lm3692x.c
··· 494 494 static int lm3692x_remove(struct i2c_client *client) 495 495 { 496 496 struct lm3692x_led *led = i2c_get_clientdata(client); 497 - int ret; 498 497 499 - ret = lm3692x_leds_disable(led); 500 - if (ret) 501 - return ret; 498 + lm3692x_leds_disable(led); 502 499 mutex_destroy(&led->lock); 503 500 504 501 return 0;