Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

s390/ap_bus: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.

Cc: Harald Freudenberger <freude@de.ibm.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

authored by

Kees Cook and committed by
Heiko Carstens
cefbeb5d c9602ee7

+7 -7
+5 -5
drivers/s390/crypto/ap_bus.c
··· 374 374 375 375 /** 376 376 * ap_request_timeout(): Handling of request timeouts 377 - * @data: Holds the AP device. 377 + * @t: timer making this callback 378 378 * 379 379 * Handles request timeouts. 380 380 */ 381 - void ap_request_timeout(unsigned long data) 381 + void ap_request_timeout(struct timer_list *t) 382 382 { 383 - struct ap_queue *aq = (struct ap_queue *) data; 383 + struct ap_queue *aq = from_timer(aq, t, timeout); 384 384 385 385 if (ap_suspend_flag) 386 386 return; ··· 1203 1203 mod_timer(&ap_config_timer, jiffies + ap_config_time * HZ); 1204 1204 } 1205 1205 1206 - static void ap_config_timeout(unsigned long ptr) 1206 + static void ap_config_timeout(struct timer_list *unused) 1207 1207 { 1208 1208 if (ap_suspend_flag) 1209 1209 return; ··· 1306 1306 goto out_bus; 1307 1307 1308 1308 /* Setup the AP bus rescan timer. */ 1309 - setup_timer(&ap_config_timer, ap_config_timeout, 0); 1309 + timer_setup(&ap_config_timer, ap_config_timeout, 0); 1310 1310 1311 1311 /* 1312 1312 * Setup the high resultion poll timer.
+1 -1
drivers/s390/crypto/ap_bus.h
··· 241 241 242 242 void *ap_airq_ptr(void); 243 243 void ap_wait(enum ap_wait wait); 244 - void ap_request_timeout(unsigned long data); 244 + void ap_request_timeout(struct timer_list *t); 245 245 void ap_bus_force_rescan(void); 246 246 247 247 void ap_queue_init_reply(struct ap_queue *aq, struct ap_message *ap_msg);
+1 -1
drivers/s390/crypto/ap_queue.c
··· 634 634 INIT_LIST_HEAD(&aq->list); 635 635 INIT_LIST_HEAD(&aq->pendingq); 636 636 INIT_LIST_HEAD(&aq->requestq); 637 - setup_timer(&aq->timeout, ap_request_timeout, (unsigned long) aq); 637 + timer_setup(&aq->timeout, ap_request_timeout, 0); 638 638 639 639 return aq; 640 640 }