Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ACPI: thinkpad-acpi: fix hotkey_get_tablet_mode

I used the wrong return convention on hotkey_get_tablet_mode(), breaking a lot
of stuff. Bad Henrique!

Fix it to return the status in the parameter-by-reference, and IO status on
the function return value. Duh.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Lukas Hejtmanek <xhejtman@ics.muni.cz>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Henrique de Moraes Holschuh and committed by
Linus Torvalds
cee47f5a acc1f3ed

+2 -1
+2 -1
drivers/misc/thinkpad_acpi.c
··· 1078 1078 if (!acpi_evalf(hkey_handle, &s, "MHKG", "d")) 1079 1079 return -EIO; 1080 1080 1081 - return ((s & TP_HOTKEY_TABLET_MASK) != 0); 1081 + *status = ((s & TP_HOTKEY_TABLET_MASK) != 0); 1082 + return 0; 1082 1083 } 1083 1084 1084 1085 /*