Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: txring_overwrite: fix incorrect test of mmap() return value

If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1).
The current if-statement incorrectly tests if *ring is NULL.

Fixes: 358be656406d ("selftests/net: add txring_overwrite")
Signed-off-by: Frank de Brabander <debrabander@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Frank de Brabander and committed by
David S. Miller
cecaa76b dd006fc4

+1 -1
+1 -1
tools/testing/selftests/net/txring_overwrite.c
··· 113 113 114 114 *ring = mmap(0, req.tp_block_size * req.tp_block_nr, 115 115 PROT_READ | PROT_WRITE, MAP_SHARED, fdt, 0); 116 - if (!*ring) 116 + if (*ring == MAP_FAILED) 117 117 error(1, errno, "mmap"); 118 118 119 119 return fdt;