Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/leds/leds-lm3530.c: move the code setting gen_config to one place

Improve the readability by moving the code setting gen_config to one
place.

[akpm@linux-foundation.org: fix some patch skew]
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
Cc: "Milo(Woogyom) Kim" <milo.kim@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Axel Lin and committed by
Linus Torvalds
cea694ca 1a1278da

+10 -8
+10 -8
drivers/leds/leds-lm3530.c
··· 160 160 gen_config = (pdata->brt_ramp_law << LM3530_RAMP_LAW_SHIFT) | 161 161 ((pdata->max_current & 7) << LM3530_MAX_CURR_SHIFT); 162 162 163 - if (drvdata->mode == LM3530_BL_MODE_MANUAL || 164 - drvdata->mode == LM3530_BL_MODE_ALS) 165 - gen_config |= (LM3530_ENABLE_I2C); 163 + switch (drvdata->mode) { 164 + case LM3530_BL_MODE_MANUAL: 165 + case LM3530_BL_MODE_ALS: 166 + gen_config |= LM3530_ENABLE_I2C; 167 + break; 168 + case LM3530_BL_MODE_PWM: 169 + gen_config |= LM3530_ENABLE_PWM | LM3530_ENABLE_PWM_SIMPLE | 170 + (pdata->pwm_pol_hi << LM3530_PWM_POL_SHIFT); 171 + break; 172 + } 166 173 167 174 if (drvdata->mode == LM3530_BL_MODE_ALS) { 168 175 if (pdata->als_vmax == 0) { ··· 202 195 (pdata->als2_resistor_sel << LM3530_ALS2_IMP_SHIFT); 203 196 204 197 } 205 - 206 - if (drvdata->mode == LM3530_BL_MODE_PWM) 207 - gen_config |= (LM3530_ENABLE_PWM) | 208 - (pdata->pwm_pol_hi << LM3530_PWM_POL_SHIFT) | 209 - (LM3530_ENABLE_PWM_SIMPLE); 210 198 211 199 brt_ramp = (pdata->brt_ramp_fall << LM3530_BRT_RAMP_FALL_SHIFT) | 212 200 (pdata->brt_ramp_rise << LM3530_BRT_RAMP_RISE_SHIFT);