Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

btrfs: remove parameter blocksize from read_tree_block

We know the tree block size, no need to pass it around.

Signed-off-by: David Sterba <dsterba@suse.cz>

+18 -37
+2 -4
fs/btrfs/backref.c
··· 490 490 continue; 491 491 BUG_ON(!ref->wanted_disk_byte); 492 492 eb = read_tree_block(fs_info->tree_root, ref->wanted_disk_byte, 493 - fs_info->tree_root->nodesize, 0); 493 + 0); 494 494 if (!eb || !extent_buffer_uptodate(eb)) { 495 495 free_extent_buffer(eb); 496 496 return -EIO; ··· 1028 1028 if (ref->count && ref->parent) { 1029 1029 if (extent_item_pos && !ref->inode_list && 1030 1030 ref->level == 0) { 1031 - u32 bsz; 1032 1031 struct extent_buffer *eb; 1033 1032 1034 - bsz = fs_info->extent_root->nodesize; 1035 1033 eb = read_tree_block(fs_info->extent_root, 1036 - ref->parent, bsz, 0); 1034 + ref->parent, 0); 1037 1035 if (!eb || !extent_buffer_uptodate(eb)) { 1038 1036 free_extent_buffer(eb); 1039 1037 ret = -EIO;
+3 -7
fs/btrfs/ctree.c
··· 1425 1425 struct tree_mod_root *old_root = NULL; 1426 1426 u64 old_generation = 0; 1427 1427 u64 logical; 1428 - u32 blocksize; 1429 1428 1430 1429 eb_root = btrfs_read_lock_root_node(root); 1431 1430 tm = __tree_mod_log_oldest_root(root->fs_info, eb_root, time_seq); ··· 1443 1444 if (old_root && tm && tm->op != MOD_LOG_KEY_REMOVE_WHILE_FREEING) { 1444 1445 btrfs_tree_read_unlock(eb_root); 1445 1446 free_extent_buffer(eb_root); 1446 - blocksize = root->nodesize; 1447 - old = read_tree_block(root, logical, blocksize, 0); 1447 + old = read_tree_block(root, logical, 0); 1448 1448 if (WARN_ON(!old || !extent_buffer_uptodate(old))) { 1449 1449 free_extent_buffer(old); 1450 1450 btrfs_warn(root->fs_info, ··· 1690 1692 uptodate = 0; 1691 1693 if (!cur || !uptodate) { 1692 1694 if (!cur) { 1693 - cur = read_tree_block(root, blocknr, 1694 - blocksize, gen); 1695 + cur = read_tree_block(root, blocknr, gen); 1695 1696 if (!cur || !extent_buffer_uptodate(cur)) { 1696 1697 free_extent_buffer(cur); 1697 1698 return -EIO; ··· 1869 1872 BUG_ON(level == 0); 1870 1873 1871 1874 eb = read_tree_block(root, btrfs_node_blockptr(parent, slot), 1872 - root->nodesize, 1873 1875 btrfs_node_ptr_generation(parent, slot)); 1874 1876 if (eb && !extent_buffer_uptodate(eb)) { 1875 1877 free_extent_buffer(eb); ··· 2503 2507 btrfs_release_path(p); 2504 2508 2505 2509 ret = -EAGAIN; 2506 - tmp = read_tree_block(root, blocknr, blocksize, 0); 2510 + tmp = read_tree_block(root, blocknr, 0); 2507 2511 if (tmp) { 2508 2512 /* 2509 2513 * If the read above didn't mark this buffer up to date,
+5 -12
fs/btrfs/disk-io.c
··· 1138 1138 } 1139 1139 1140 1140 struct extent_buffer *read_tree_block(struct btrfs_root *root, u64 bytenr, 1141 - u32 blocksize, u64 parent_transid) 1141 + u64 parent_transid) 1142 1142 { 1143 1143 struct extent_buffer *buf = NULL; 1144 1144 int ret; 1145 1145 1146 - buf = btrfs_find_create_tree_block(root, bytenr, blocksize); 1146 + buf = btrfs_find_create_tree_block(root, bytenr, root->nodesize); 1147 1147 if (!buf) 1148 1148 return NULL; 1149 1149 ··· 1484 1484 struct btrfs_fs_info *fs_info = tree_root->fs_info; 1485 1485 struct btrfs_path *path; 1486 1486 u64 generation; 1487 - u32 blocksize; 1488 1487 int ret; 1489 1488 1490 1489 path = btrfs_alloc_path(); ··· 1508 1509 } 1509 1510 1510 1511 generation = btrfs_root_generation(&root->root_item); 1511 - blocksize = root->nodesize; 1512 1512 root->node = read_tree_block(root, btrfs_root_bytenr(&root->root_item), 1513 - blocksize, generation); 1513 + generation); 1514 1514 if (!root->node) { 1515 1515 ret = -ENOMEM; 1516 1516 goto find_fail; ··· 2137 2139 { 2138 2140 u32 sectorsize; 2139 2141 u32 nodesize; 2140 - u32 blocksize; 2141 2142 u32 stripesize; 2142 2143 u64 generation; 2143 2144 u64 features; ··· 2640 2643 goto fail_sb_buffer; 2641 2644 } 2642 2645 2643 - blocksize = tree_root->nodesize; 2644 2646 generation = btrfs_super_chunk_root_generation(disk_super); 2645 2647 2646 2648 __setup_root(nodesize, sectorsize, stripesize, chunk_root, ··· 2647 2651 2648 2652 chunk_root->node = read_tree_block(chunk_root, 2649 2653 btrfs_super_chunk_root(disk_super), 2650 - blocksize, generation); 2654 + generation); 2651 2655 if (!chunk_root->node || 2652 2656 !test_bit(EXTENT_BUFFER_UPTODATE, &chunk_root->node->bflags)) { 2653 2657 printk(KERN_WARNING "BTRFS: failed to read chunk root on %s\n", ··· 2680 2684 } 2681 2685 2682 2686 retry_root_backup: 2683 - blocksize = tree_root->nodesize; 2684 2687 generation = btrfs_super_generation(disk_super); 2685 2688 2686 2689 tree_root->node = read_tree_block(tree_root, 2687 2690 btrfs_super_root(disk_super), 2688 - blocksize, generation); 2691 + generation); 2689 2692 if (!tree_root->node || 2690 2693 !test_bit(EXTENT_BUFFER_UPTODATE, &tree_root->node->bflags)) { 2691 2694 printk(KERN_WARNING "BTRFS: failed to read tree root on %s\n", ··· 2853 2858 err = -EIO; 2854 2859 goto fail_qgroup; 2855 2860 } 2856 - blocksize = tree_root->nodesize; 2857 2861 2858 2862 log_tree_root = btrfs_alloc_root(fs_info); 2859 2863 if (!log_tree_root) { ··· 2864 2870 log_tree_root, fs_info, BTRFS_TREE_LOG_OBJECTID); 2865 2871 2866 2872 log_tree_root->node = read_tree_block(tree_root, bytenr, 2867 - blocksize, 2868 2873 generation + 1); 2869 2874 if (!log_tree_root->node || 2870 2875 !extent_buffer_uptodate(log_tree_root->node)) {
+1 -1
fs/btrfs/disk-io.h
··· 45 45 struct btrfs_fs_devices; 46 46 47 47 struct extent_buffer *read_tree_block(struct btrfs_root *root, u64 bytenr, 48 - u32 blocksize, u64 parent_transid); 48 + u64 parent_transid); 49 49 void readahead_tree_block(struct btrfs_root *root, u64 bytenr, u32 blocksize); 50 50 int reada_tree_block_flagged(struct btrfs_root *root, u64 bytenr, u32 blocksize, 51 51 int mirror_num, struct extent_buffer **eb);
+3 -5
fs/btrfs/extent-tree.c
··· 7645 7645 level = root_level; 7646 7646 while (level >= 0) { 7647 7647 if (path->nodes[level] == NULL) { 7648 - int child_bsize = root->nodesize; 7649 7648 int parent_slot; 7650 7649 u64 child_gen; 7651 7650 u64 child_bytenr; ··· 7656 7657 child_bytenr = btrfs_node_blockptr(eb, parent_slot); 7657 7658 child_gen = btrfs_node_ptr_generation(eb, parent_slot); 7658 7659 7659 - eb = read_tree_block(root, child_bytenr, child_bsize, 7660 - child_gen); 7660 + eb = read_tree_block(root, child_bytenr, child_gen); 7661 7661 if (!eb || !extent_buffer_uptodate(eb)) { 7662 7662 ret = -EIO; 7663 7663 goto out; ··· 7672 7674 ret = btrfs_qgroup_record_ref(trans, root->fs_info, 7673 7675 root->objectid, 7674 7676 child_bytenr, 7675 - child_bsize, 7677 + root->nodesize, 7676 7678 BTRFS_QGROUP_OPER_SUB_SUBTREE, 7677 7679 0); 7678 7680 if (ret) ··· 7887 7889 if (!next) { 7888 7890 if (reada && level == 1) 7889 7891 reada_walk_down(trans, root, wc, path); 7890 - next = read_tree_block(root, bytenr, blocksize, generation); 7892 + next = read_tree_block(root, bytenr, generation); 7891 7893 if (!next || !extent_buffer_uptodate(next)) { 7892 7894 free_extent_buffer(next); 7893 7895 return -EIO;
-1
fs/btrfs/print-tree.c
··· 336 336 for (i = 0; i < nr; i++) { 337 337 struct extent_buffer *next = read_tree_block(root, 338 338 btrfs_node_blockptr(c, i), 339 - root->nodesize, 340 339 btrfs_node_ptr_generation(c, i)); 341 340 if (btrfs_is_leaf(next) && 342 341 level != 1)
+4 -7
fs/btrfs/relocation.c
··· 1813 1813 break; 1814 1814 } 1815 1815 1816 - eb = read_tree_block(dest, old_bytenr, blocksize, 1817 - old_ptr_gen); 1816 + eb = read_tree_block(dest, old_bytenr, old_ptr_gen); 1818 1817 if (!eb || !extent_buffer_uptodate(eb)) { 1819 1818 ret = (!eb) ? -ENOMEM : -EIO; 1820 1819 free_extent_buffer(eb); ··· 1943 1944 u64 bytenr; 1944 1945 u64 ptr_gen = 0; 1945 1946 u64 last_snapshot; 1946 - u32 blocksize; 1947 1947 u32 nritems; 1948 1948 1949 1949 last_snapshot = btrfs_root_last_snapshot(&root->root_item); ··· 1968 1970 } 1969 1971 1970 1972 bytenr = btrfs_node_blockptr(eb, path->slots[i]); 1971 - blocksize = root->nodesize; 1972 - eb = read_tree_block(root, bytenr, blocksize, ptr_gen); 1973 + eb = read_tree_block(root, bytenr, ptr_gen); 1973 1974 if (!eb || !extent_buffer_uptodate(eb)) { 1974 1975 free_extent_buffer(eb); 1975 1976 return -EIO; ··· 2677 2680 2678 2681 blocksize = root->nodesize; 2679 2682 generation = btrfs_node_ptr_generation(upper->eb, slot); 2680 - eb = read_tree_block(root, bytenr, blocksize, generation); 2683 + eb = read_tree_block(root, bytenr, generation); 2681 2684 if (!eb || !extent_buffer_uptodate(eb)) { 2682 2685 free_extent_buffer(eb); 2683 2686 err = -EIO; ··· 2839 2842 2840 2843 BUG_ON(block->key_ready); 2841 2844 eb = read_tree_block(rc->extent_root, block->bytenr, 2842 - block->key.objectid, block->key.offset); 2845 + block->key.offset); 2843 2846 if (!eb || !extent_buffer_uptodate(eb)) { 2844 2847 free_extent_buffer(eb); 2845 2848 return -EIO;