Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/bridge/panel: Fix runtime warning on panel bridge release

Device managed panel bridge wrappers are created by calling to
drm_panel_bridge_add_typed() and registering a release handler for
clean-up when the device gets unbound.

Since the memory for this bridge is also managed and linked to the panel
device, the release function should not try to free that memory.
Moreover, the call to devm_kfree() inside drm_panel_bridge_remove() will
fail in this case and emit a warning because the panel bridge resource
is no longer on the device resources list (it has been removed from
there before the call to release handlers).

Fixes: 67022227ffb1 ("drm/bridge: Add a devm_ allocator for panel bridge.")
Signed-off-by: Adam Miotk <adam.miotk@arm.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240610102739.139852-1-adam.miotk@arm.com

authored by

Adam Miotk and committed by
Maxime Ripard
ce62600c b880018e

+5 -2
+5 -2
drivers/gpu/drm/bridge/panel.c
··· 360 360 361 361 static void devm_drm_panel_bridge_release(struct device *dev, void *res) 362 362 { 363 - struct drm_bridge **bridge = res; 363 + struct drm_bridge *bridge = *(struct drm_bridge **)res; 364 364 365 - drm_panel_bridge_remove(*bridge); 365 + if (!bridge) 366 + return; 367 + 368 + drm_bridge_remove(bridge); 366 369 } 367 370 368 371 /**