Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: hisi_sas: shift vs compare typos

There are some typos where we intended "<<" but have "<". Seems likely
to cause a bunch of problems.

Fixes: d3b688d3c69d ("scsi: hisi_sas: add v2 hw support for ECC and AXI bus fatal error")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Dan Carpenter and committed by
Martin K. Petersen
ce41b41e aa8c65a4

+6 -6
+6 -6
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
··· 64 64 HGC_LM_DFX_STATUS2_ITCTLIST_OFF) 65 65 #define HGC_CQE_ECC_ADDR 0x13c 66 66 #define HGC_CQE_ECC_1B_ADDR_OFF 0 67 - #define HGC_CQE_ECC_1B_ADDR_MSK (0x3f < HGC_CQE_ECC_1B_ADDR_OFF) 67 + #define HGC_CQE_ECC_1B_ADDR_MSK (0x3f << HGC_CQE_ECC_1B_ADDR_OFF) 68 68 #define HGC_CQE_ECC_MB_ADDR_OFF 8 69 - #define HGC_CQE_ECC_MB_ADDR_MSK (0x3f < HGC_CQE_ECC_MB_ADDR_OFF) 69 + #define HGC_CQE_ECC_MB_ADDR_MSK (0x3f << HGC_CQE_ECC_MB_ADDR_OFF) 70 70 #define HGC_IOST_ECC_ADDR 0x140 71 71 #define HGC_IOST_ECC_1B_ADDR_OFF 0 72 - #define HGC_IOST_ECC_1B_ADDR_MSK (0x3ff < HGC_IOST_ECC_1B_ADDR_OFF) 72 + #define HGC_IOST_ECC_1B_ADDR_MSK (0x3ff << HGC_IOST_ECC_1B_ADDR_OFF) 73 73 #define HGC_IOST_ECC_MB_ADDR_OFF 16 74 - #define HGC_IOST_ECC_MB_ADDR_MSK (0x3ff < HGC_IOST_ECC_MB_ADDR_OFF) 74 + #define HGC_IOST_ECC_MB_ADDR_MSK (0x3ff << HGC_IOST_ECC_MB_ADDR_OFF) 75 75 #define HGC_DQE_ECC_ADDR 0x144 76 76 #define HGC_DQE_ECC_1B_ADDR_OFF 0 77 - #define HGC_DQE_ECC_1B_ADDR_MSK (0xfff < HGC_DQE_ECC_1B_ADDR_OFF) 77 + #define HGC_DQE_ECC_1B_ADDR_MSK (0xfff << HGC_DQE_ECC_1B_ADDR_OFF) 78 78 #define HGC_DQE_ECC_MB_ADDR_OFF 16 79 - #define HGC_DQE_ECC_MB_ADDR_MSK (0xfff < HGC_DQE_ECC_MB_ADDR_OFF) 79 + #define HGC_DQE_ECC_MB_ADDR_MSK (0xfff << HGC_DQE_ECC_MB_ADDR_OFF) 80 80 #define HGC_INVLD_DQE_INFO 0x148 81 81 #define HGC_INVLD_DQE_INFO_FB_CH0_OFF 9 82 82 #define HGC_INVLD_DQE_INFO_FB_CH0_MSK (0x1 << HGC_INVLD_DQE_INFO_FB_CH0_OFF)