Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

Since we lack the hardware (or proper emulator setup) for
testing needed changes add FIXMEs to document the issues
(so at least they are not forgotten).

Cc: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/380c0494-ed02-b2be-65b0-d385627fb894@samsung.com

+2
+2
drivers/video/fbdev/amifb.c
··· 1890 1890 | ((datawords >> 15) & 1)); 1891 1891 datawords <<= 1; 1892 1892 #endif 1893 + /* FIXME: check the return value + test the change */ 1893 1894 put_user(color, data++); 1894 1895 } 1895 1896 if (bits > 0) { ··· 1959 1958 bits = 16; words = delta; datawords = 0; 1960 1959 for (width = (short)var->width - 1; width >= 0; width--) { 1961 1960 unsigned long tdata = 0; 1961 + /* FIXME: check the return value + test the change */ 1962 1962 get_user(tdata, data); 1963 1963 data++; 1964 1964 #ifdef __mc68000__