Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: lpfc: Annotate switch/case fall-through

This patch avoids that the compiler warns about missing fall-through
annotation when building with W=1.

Cc: James Smart <james.smart@broadcom.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen
cd05c155 ffd43814

+13 -6
+2
drivers/scsi/lpfc/lpfc_ct.c
··· 3099 3099 case SLI_MGMT_GHAT: 3100 3100 case SLI_MGMT_GRPL: 3101 3101 rsp_size = FC_MAX_NS_RSP; 3102 + /* fall through */ 3102 3103 case SLI_MGMT_DHBA: 3103 3104 case SLI_MGMT_DHAT: 3104 3105 pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; ··· 3112 3111 case SLI_MGMT_GPAT: 3113 3112 case SLI_MGMT_GPAS: 3114 3113 rsp_size = FC_MAX_NS_RSP; 3114 + /* fall through */ 3115 3115 case SLI_MGMT_DPRT: 3116 3116 case SLI_MGMT_DPA: 3117 3117 pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
+1 -1
drivers/scsi/lpfc/lpfc_els.c
··· 8775 8775 lpfc_nlp_put(ndlp); 8776 8776 return; 8777 8777 } 8778 - 8778 + /* fall through */ 8779 8779 default: 8780 8780 /* Try to recover from this error */ 8781 8781 if (phba->sli_rev == LPFC_SLI_REV4)
+4 -1
drivers/scsi/lpfc/lpfc_hbadisc.c
··· 4666 4666 case CMD_GEN_REQUEST64_CR: 4667 4667 if (iocb->context_un.ndlp == ndlp) 4668 4668 return 1; 4669 + /* fall through */ 4669 4670 case CMD_ELS_REQUEST64_CR: 4670 4671 if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID) 4671 4672 return 1; 4673 + /* fall through */ 4672 4674 case CMD_XMIT_ELS_RSP64_CX: 4673 4675 if (iocb->context1 == (uint8_t *) ndlp) 4674 4676 return 1; 4677 + /* fall through */ 4675 4678 } 4676 4679 } else if (pring->ringno == LPFC_FCP_RING) { 4677 4680 /* Skip match check if waiting to relogin to FCP target */ ··· 5866 5863 5867 5864 case LPFC_LINK_UP: 5868 5865 lpfc_issue_clear_la(phba, vport); 5869 - /* Drop thru */ 5866 + /* fall through */ 5870 5867 case LPFC_LINK_UNKNOWN: 5871 5868 case LPFC_WARM_START: 5872 5869 case LPFC_INIT_START:
+1
drivers/scsi/lpfc/lpfc_nportdisc.c
··· 360 360 case NLP_STE_NPR_NODE: 361 361 if (!(ndlp->nlp_flag & NLP_NPR_ADISC)) 362 362 break; 363 + /* fall through */ 363 364 case NLP_STE_REG_LOGIN_ISSUE: 364 365 case NLP_STE_PRLI_ISSUE: 365 366 case NLP_STE_UNMAPPED_NODE:
+1
drivers/scsi/lpfc/lpfc_nvme.c
··· 1106 1106 lpfc_ncmd, nCmd, 1107 1107 lpfc_ncmd->cur_iocbq.sli4_xritag, 1108 1108 bf_get(lpfc_wcqe_c_xb, wcqe)); 1109 + /* fall through */ 1109 1110 default: 1110 1111 out_err: 1111 1112 lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR,
+4 -4
drivers/scsi/lpfc/lpfc_scsi.c
··· 1137 1137 1138 1138 break; 1139 1139 } 1140 - /* Drop thru */ 1140 + /* fall through */ 1141 1141 case SCSI_PROT_WRITE_INSERT: 1142 1142 /* 1143 1143 * For WRITE_INSERT, force the error ··· 1256 1256 rc = BG_ERR_TGT | BG_ERR_CHECK; 1257 1257 break; 1258 1258 } 1259 - /* Drop thru */ 1259 + /* fall through */ 1260 1260 case SCSI_PROT_WRITE_INSERT: 1261 1261 /* 1262 1262 * For WRITE_INSERT, force the ··· 1338 1338 switch (op) { 1339 1339 case SCSI_PROT_WRITE_PASS: 1340 1340 rc = BG_ERR_CHECK; 1341 - /* Drop thru */ 1341 + /* fall through */ 1342 1342 1343 1343 case SCSI_PROT_WRITE_INSERT: 1344 1344 /* ··· 3822 3822 lpfc_cmd->cur_iocbq.sli4_lxritag, 3823 3823 0, 0); 3824 3824 } 3825 - /* else: fall through */ 3825 + /* fall through */ 3826 3826 default: 3827 3827 cmd->result = DID_ERROR << 16; 3828 3828 break;