Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

wilc1000: let wilc_mac_xmit() return NETDEV_TX_OK

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type defining 'NETDEV_TX_OK' but this
driver returns '0' instead of 'NETDEV_TX_OK'.

Fix this by returning 'NETDEV_TX_OK' instead of '0'.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200629104009.84077-1-luc.vanoostenryck@gmail.com

authored by

Luc Van Oostenryck and committed by
Kalle Valo
cce0e083 b52b331a

+3 -3
+3 -3
drivers/net/wireless/microchip/wilc1000/netdev.c
··· 684 684 685 685 if (skb->dev != ndev) { 686 686 netdev_err(ndev, "Packet not destined to this device\n"); 687 - return 0; 687 + return NETDEV_TX_OK; 688 688 } 689 689 690 690 tx_data = kmalloc(sizeof(*tx_data), GFP_ATOMIC); 691 691 if (!tx_data) { 692 692 dev_kfree_skb(skb); 693 693 netif_wake_queue(ndev); 694 - return 0; 694 + return NETDEV_TX_OK; 695 695 } 696 696 697 697 tx_data->buff = skb->data; ··· 716 716 srcu_read_unlock(&wilc->srcu, srcu_idx); 717 717 } 718 718 719 - return 0; 719 + return NETDEV_TX_OK; 720 720 } 721 721 722 722 static int wilc_mac_close(struct net_device *ndev)