Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pwm: bcm-kona: Simplify using devm_pwmchip_add()

This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

authored by

Uwe Kleine-König and committed by
Thierry Reding
ccc2df6f 14ac9e17

+1 -11
+1 -11
drivers/pwm/pwm-bcm-kona.c
··· 267 267 if (kp == NULL) 268 268 return -ENOMEM; 269 269 270 - platform_set_drvdata(pdev, kp); 271 - 272 270 kp->chip.dev = &pdev->dev; 273 271 kp->chip.ops = &kona_pwm_ops; 274 272 kp->chip.npwm = 6; ··· 296 298 297 299 clk_disable_unprepare(kp->clk); 298 300 299 - ret = pwmchip_add(&kp->chip); 301 + ret = devm_pwmchip_add(&pdev->dev, &kp->chip); 300 302 if (ret < 0) 301 303 dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret); 302 304 303 305 return ret; 304 - } 305 - 306 - static int kona_pwmc_remove(struct platform_device *pdev) 307 - { 308 - struct kona_pwmc *kp = platform_get_drvdata(pdev); 309 - 310 - return pwmchip_remove(&kp->chip); 311 306 } 312 307 313 308 static const struct of_device_id bcm_kona_pwmc_dt[] = { ··· 315 324 .of_match_table = bcm_kona_pwmc_dt, 316 325 }, 317 326 .probe = kona_pwmc_probe, 318 - .remove = kona_pwmc_remove, 319 327 }; 320 328 module_platform_driver(kona_pwmc_driver); 321 329