Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: mei: csi: Warn less verbosely of a missing device fwnode

The check for having device fwnode was meant to be a sanity check but this
also happens if the ACPI DSDT has graph port nodes on sensor device(s) but
not on the IVSC device. Use a more meaningful warning message to tell
about this.

Fixes: 33116eb12c6b ("media: ivsc: csi: Use IPU bridge")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Sakari Ailus and committed by
Hans Verkuil
cc864821 328af04b

+3 -1
+3 -1
drivers/media/pci/intel/ivsc/mei_csi.c
··· 680 put_device(&ipu->dev); 681 if (ret < 0) 682 return ret; 683 - if (WARN_ON(!dev_fwnode(dev))) 684 return -ENXIO; 685 686 csi = devm_kzalloc(dev, sizeof(struct mei_csi), GFP_KERNEL); 687 if (!csi)
··· 680 put_device(&ipu->dev); 681 if (ret < 0) 682 return ret; 683 + if (!dev_fwnode(dev)) { 684 + dev_err(dev, "mei-csi probed without device fwnode!\n"); 685 return -ENXIO; 686 + } 687 688 csi = devm_kzalloc(dev, sizeof(struct mei_csi), GFP_KERNEL); 689 if (!csi)