Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

watchdog: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it was merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230726233302.3812749-1-robh@kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Rob Herring and committed by
Wim Van Sebroeck
cc85f87a ef9e7fe2

+24 -38
-1
drivers/watchdog/armada_37xx_wdt.c
··· 14 14 #include <linux/module.h> 15 15 #include <linux/moduleparam.h> 16 16 #include <linux/of.h> 17 - #include <linux/of_device.h> 18 17 #include <linux/platform_device.h> 19 18 #include <linux/regmap.h> 20 19 #include <linux/types.h>
+1 -2
drivers/watchdog/at91rm9200_wdt.c
··· 18 18 #include <linux/mfd/syscon.h> 19 19 #include <linux/mfd/syscon/atmel-st.h> 20 20 #include <linux/miscdevice.h> 21 + #include <linux/mod_devicetable.h> 21 22 #include <linux/module.h> 22 23 #include <linux/moduleparam.h> 23 24 #include <linux/platform_device.h> ··· 27 26 #include <linux/types.h> 28 27 #include <linux/watchdog.h> 29 28 #include <linux/uaccess.h> 30 - #include <linux/of.h> 31 - #include <linux/of_device.h> 32 29 33 30 #define WDT_DEFAULT_TIME 5 /* seconds */ 34 31 #define WDT_MAX_TIME 256 /* seconds */
+1 -1
drivers/watchdog/cpwd.c
··· 31 31 #include <linux/mutex.h> 32 32 #include <linux/io.h> 33 33 #include <linux/of.h> 34 - #include <linux/of_device.h> 34 + #include <linux/platform_device.h> 35 35 #include <linux/uaccess.h> 36 36 37 37 #include <asm/irq.h>
+2 -4
drivers/watchdog/ftwdt010_wdt.c
··· 14 14 #include <linux/io.h> 15 15 #include <linux/kernel.h> 16 16 #include <linux/module.h> 17 - #include <linux/of_device.h> 17 + #include <linux/mod_devicetable.h> 18 18 #include <linux/platform_device.h> 19 19 #include <linux/slab.h> 20 20 #include <linux/watchdog.h> ··· 221 221 ftwdt010_wdt_resume) 222 222 }; 223 223 224 - #ifdef CONFIG_OF 225 224 static const struct of_device_id ftwdt010_wdt_match[] = { 226 225 { .compatible = "faraday,ftwdt010" }, 227 226 { .compatible = "cortina,gemini-watchdog" }, 228 227 {}, 229 228 }; 230 229 MODULE_DEVICE_TABLE(of, ftwdt010_wdt_match); 231 - #endif 232 230 233 231 static struct platform_driver ftwdt010_wdt_driver = { 234 232 .probe = ftwdt010_wdt_probe, 235 233 .driver = { 236 234 .name = "ftwdt010-wdt", 237 - .of_match_table = of_match_ptr(ftwdt010_wdt_match), 235 + .of_match_table = ftwdt010_wdt_match, 238 236 .pm = &ftwdt010_wdt_dev_pm_ops, 239 237 }, 240 238 };
+1 -1
drivers/watchdog/gef_wdt.c
··· 31 31 #include <linux/fs.h> 32 32 #include <linux/of.h> 33 33 #include <linux/of_address.h> 34 - #include <linux/of_platform.h> 34 + #include <linux/platform_device.h> 35 35 #include <linux/io.h> 36 36 #include <linux/uaccess.h> 37 37
+1 -2
drivers/watchdog/imx2_wdt.c
··· 26 26 #include <linux/kernel.h> 27 27 #include <linux/module.h> 28 28 #include <linux/moduleparam.h> 29 - #include <linux/of_address.h> 30 - #include <linux/of_device.h> 29 + #include <linux/of.h> 31 30 #include <linux/platform_device.h> 32 31 #include <linux/regmap.h> 33 32 #include <linux/watchdog.h>
-1
drivers/watchdog/imx7ulp_wdt.c
··· 9 9 #include <linux/kernel.h> 10 10 #include <linux/module.h> 11 11 #include <linux/of.h> 12 - #include <linux/of_device.h> 13 12 #include <linux/platform_device.h> 14 13 #include <linux/reboot.h> 15 14 #include <linux/watchdog.h>
+2 -1
drivers/watchdog/lantiq_wdt.c
··· 9 9 #include <linux/module.h> 10 10 #include <linux/bitops.h> 11 11 #include <linux/watchdog.h> 12 - #include <linux/of_platform.h> 12 + #include <linux/of.h> 13 + #include <linux/platform_device.h> 13 14 #include <linux/uaccess.h> 14 15 #include <linux/clk.h> 15 16 #include <linux/io.h>
+2 -2
drivers/watchdog/meson_wdt.c
··· 11 11 #include <linux/init.h> 12 12 #include <linux/io.h> 13 13 #include <linux/kernel.h> 14 + #include <linux/mod_devicetable.h> 14 15 #include <linux/module.h> 15 16 #include <linux/moduleparam.h> 16 - #include <linux/of.h> 17 - #include <linux/of_device.h> 18 17 #include <linux/platform_device.h> 18 + #include <linux/property.h> 19 19 #include <linux/types.h> 20 20 #include <linux/watchdog.h> 21 21
+2 -2
drivers/watchdog/mpc8xxx_wdt.c
··· 16 16 #include <linux/fs.h> 17 17 #include <linux/init.h> 18 18 #include <linux/kernel.h> 19 - #include <linux/of_address.h> 20 - #include <linux/of_platform.h> 19 + #include <linux/of.h> 20 + #include <linux/platform_device.h> 21 21 #include <linux/module.h> 22 22 #include <linux/watchdog.h> 23 23 #include <linux/io.h>
-1
drivers/watchdog/mtk_wdt.c
··· 25 25 #include <linux/module.h> 26 26 #include <linux/moduleparam.h> 27 27 #include <linux/of.h> 28 - #include <linux/of_device.h> 29 28 #include <linux/platform_device.h> 30 29 #include <linux/reset-controller.h> 31 30 #include <linux/types.h>
+1 -2
drivers/watchdog/of_xilinx_wdt.c
··· 10 10 #include <linux/clk.h> 11 11 #include <linux/err.h> 12 12 #include <linux/module.h> 13 + #include <linux/platform_device.h> 13 14 #include <linux/types.h> 14 15 #include <linux/kernel.h> 15 16 #include <linux/ioport.h> 16 17 #include <linux/watchdog.h> 17 18 #include <linux/io.h> 18 19 #include <linux/of.h> 19 - #include <linux/of_device.h> 20 - #include <linux/of_address.h> 21 20 22 21 /* Register offsets for the Wdt device */ 23 22 #define XWT_TWCSR0_OFFSET 0x0 /* Control/Status Register0 */
-1
drivers/watchdog/pic32-dmt.c
··· 12 12 #include <linux/kernel.h> 13 13 #include <linux/module.h> 14 14 #include <linux/of.h> 15 - #include <linux/of_device.h> 16 15 #include <linux/platform_device.h> 17 16 #include <linux/pm.h> 18 17 #include <linux/watchdog.h>
-1
drivers/watchdog/pic32-wdt.c
··· 12 12 #include <linux/kernel.h> 13 13 #include <linux/module.h> 14 14 #include <linux/of.h> 15 - #include <linux/of_device.h> 16 15 #include <linux/platform_device.h> 17 16 #include <linux/pm.h> 18 17 #include <linux/watchdog.h>
+1 -1
drivers/watchdog/pika_wdt.c
··· 23 23 #include <linux/bitops.h> 24 24 #include <linux/uaccess.h> 25 25 #include <linux/io.h> 26 + #include <linux/of.h> 26 27 #include <linux/of_address.h> 27 - #include <linux/of_platform.h> 28 28 29 29 #define DRV_NAME "PIKA-WDT" 30 30
-1
drivers/watchdog/qcom-wdt.c
··· 11 11 #include <linux/of.h> 12 12 #include <linux/platform_device.h> 13 13 #include <linux/watchdog.h> 14 - #include <linux/of_device.h> 15 14 16 15 enum wdt_reg { 17 16 WDT_RST,
+1 -1
drivers/watchdog/rave-sp-wdt.c
··· 13 13 #include <linux/mfd/rave-sp.h> 14 14 #include <linux/module.h> 15 15 #include <linux/nvmem-consumer.h> 16 - #include <linux/of_device.h> 16 + #include <linux/of.h> 17 17 #include <linux/platform_device.h> 18 18 #include <linux/reboot.h> 19 19 #include <linux/slab.h>
+1 -1
drivers/watchdog/riowd.c
··· 14 14 #include <linux/miscdevice.h> 15 15 #include <linux/watchdog.h> 16 16 #include <linux/of.h> 17 - #include <linux/of_device.h> 17 + #include <linux/platform_device.h> 18 18 #include <linux/io.h> 19 19 #include <linux/uaccess.h> 20 20 #include <linux/slab.h>
+2 -2
drivers/watchdog/rza_wdt.c
··· 9 9 #include <linux/bitops.h> 10 10 #include <linux/clk.h> 11 11 #include <linux/delay.h> 12 + #include <linux/io.h> 12 13 #include <linux/module.h> 13 - #include <linux/of_address.h> 14 - #include <linux/of_device.h> 14 + #include <linux/of.h> 15 15 #include <linux/platform_device.h> 16 16 #include <linux/watchdog.h> 17 17
+1 -1
drivers/watchdog/rzg2l_wdt.c
··· 11 11 #include <linux/iopoll.h> 12 12 #include <linux/kernel.h> 13 13 #include <linux/module.h> 14 - #include <linux/of_device.h> 14 + #include <linux/of.h> 15 15 #include <linux/platform_device.h> 16 16 #include <linux/pm_runtime.h> 17 17 #include <linux/reset.h>
-1
drivers/watchdog/s3c2410_wdt.c
··· 23 23 #include <linux/slab.h> 24 24 #include <linux/err.h> 25 25 #include <linux/of.h> 26 - #include <linux/of_device.h> 27 26 #include <linux/mfd/syscon.h> 28 27 #include <linux/regmap.h> 29 28 #include <linux/delay.h>
-1
drivers/watchdog/sama5d4_wdt.c
··· 11 11 #include <linux/kernel.h> 12 12 #include <linux/module.h> 13 13 #include <linux/of.h> 14 - #include <linux/of_device.h> 15 14 #include <linux/of_irq.h> 16 15 #include <linux/platform_device.h> 17 16 #include <linux/reboot.h>
+1 -2
drivers/watchdog/sbsa_gwdt.c
··· 43 43 #include <linux/io.h> 44 44 #include <linux/io-64-nonatomic-lo-hi.h> 45 45 #include <linux/interrupt.h> 46 + #include <linux/mod_devicetable.h> 46 47 #include <linux/module.h> 47 48 #include <linux/moduleparam.h> 48 - #include <linux/of.h> 49 - #include <linux/of_device.h> 50 49 #include <linux/platform_device.h> 51 50 #include <linux/uaccess.h> 52 51 #include <linux/watchdog.h>
+2 -1
drivers/watchdog/starfive-wdt.c
··· 8 8 #include <linux/clk.h> 9 9 #include <linux/iopoll.h> 10 10 #include <linux/module.h> 11 - #include <linux/of_device.h> 11 + #include <linux/of.h> 12 + #include <linux/platform_device.h> 12 13 #include <linux/pm_runtime.h> 13 14 #include <linux/reset.h> 14 15 #include <linux/watchdog.h>
-1
drivers/watchdog/stm32_iwdg.c
··· 17 17 #include <linux/kernel.h> 18 18 #include <linux/module.h> 19 19 #include <linux/of.h> 20 - #include <linux/of_device.h> 21 20 #include <linux/platform_device.h> 22 21 #include <linux/watchdog.h> 23 22
-1
drivers/watchdog/sunxi_wdt.c
··· 18 18 #include <linux/module.h> 19 19 #include <linux/moduleparam.h> 20 20 #include <linux/of.h> 21 - #include <linux/of_device.h> 22 21 #include <linux/platform_device.h> 23 22 #include <linux/types.h> 24 23 #include <linux/watchdog.h>
+2 -2
drivers/watchdog/xilinx_wwdt.c
··· 9 9 #include <linux/interrupt.h> 10 10 #include <linux/io.h> 11 11 #include <linux/ioport.h> 12 + #include <linux/mod_devicetable.h> 12 13 #include <linux/module.h> 13 - #include <linux/of_device.h> 14 - #include <linux/of_address.h> 14 + #include <linux/platform_device.h> 15 15 #include <linux/watchdog.h> 16 16 17 17 /* Max timeout is calculated at 100MHz source clock */