Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: omapfb: replace snprintf in show functions with sysfs_emit

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1634095693-4428-1-git-send-email-wangqing@vivo.com

authored by

Qing Wang and committed by
Sam Ravnborg
cc83ff24 4701a0dd

+32 -32
+7 -7
drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c
··· 19 19 20 20 static ssize_t display_name_show(struct omap_dss_device *dssdev, char *buf) 21 21 { 22 - return snprintf(buf, PAGE_SIZE, "%s\n", 22 + return sysfs_emit(buf, "%s\n", 23 23 dssdev->name ? 24 24 dssdev->name : ""); 25 25 } 26 26 27 27 static ssize_t display_enabled_show(struct omap_dss_device *dssdev, char *buf) 28 28 { 29 - return snprintf(buf, PAGE_SIZE, "%d\n", 29 + return sysfs_emit(buf, "%d\n", 30 30 omapdss_device_is_enabled(dssdev)); 31 31 } 32 32 ··· 59 59 60 60 static ssize_t display_tear_show(struct omap_dss_device *dssdev, char *buf) 61 61 { 62 - return snprintf(buf, PAGE_SIZE, "%d\n", 62 + return sysfs_emit(buf, "%d\n", 63 63 dssdev->driver->get_te ? 64 64 dssdev->driver->get_te(dssdev) : 0); 65 65 } ··· 93 93 94 94 dssdev->driver->get_timings(dssdev, &t); 95 95 96 - return snprintf(buf, PAGE_SIZE, "%u,%u/%u/%u/%u,%u/%u/%u/%u\n", 96 + return sysfs_emit(buf, "%u,%u/%u/%u/%u,%u/%u/%u/%u\n", 97 97 t.pixelclock, 98 98 t.x_res, t.hfp, t.hbp, t.hsw, 99 99 t.y_res, t.vfp, t.vbp, t.vsw); ··· 143 143 if (!dssdev->driver->get_rotate) 144 144 return -ENOENT; 145 145 rotate = dssdev->driver->get_rotate(dssdev); 146 - return snprintf(buf, PAGE_SIZE, "%u\n", rotate); 146 + return sysfs_emit(buf, "%u\n", rotate); 147 147 } 148 148 149 149 static ssize_t display_rotate_store(struct omap_dss_device *dssdev, ··· 171 171 if (!dssdev->driver->get_mirror) 172 172 return -ENOENT; 173 173 mirror = dssdev->driver->get_mirror(dssdev); 174 - return snprintf(buf, PAGE_SIZE, "%u\n", mirror); 174 + return sysfs_emit(buf, "%u\n", mirror); 175 175 } 176 176 177 177 static ssize_t display_mirror_store(struct omap_dss_device *dssdev, ··· 203 203 204 204 wss = dssdev->driver->get_wss(dssdev); 205 205 206 - return snprintf(buf, PAGE_SIZE, "0x%05x\n", wss); 206 + return sysfs_emit(buf, "0x%05x\n", wss); 207 207 } 208 208 209 209 static ssize_t display_wss_store(struct omap_dss_device *dssdev,
+9 -9
drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c
··· 22 22 23 23 static ssize_t manager_name_show(struct omap_overlay_manager *mgr, char *buf) 24 24 { 25 - return snprintf(buf, PAGE_SIZE, "%s\n", mgr->name); 25 + return sysfs_emit(buf, "%s\n", mgr->name); 26 26 } 27 27 28 28 static ssize_t manager_display_show(struct omap_overlay_manager *mgr, char *buf) 29 29 { 30 30 struct omap_dss_device *dssdev = mgr->get_device(mgr); 31 31 32 - return snprintf(buf, PAGE_SIZE, "%s\n", dssdev ? 32 + return sysfs_emit(buf, "%s\n", dssdev ? 33 33 dssdev->name : "<none>"); 34 34 } 35 35 ··· 120 120 121 121 mgr->get_manager_info(mgr, &info); 122 122 123 - return snprintf(buf, PAGE_SIZE, "%#x\n", info.default_color); 123 + return sysfs_emit(buf, "%#x\n", info.default_color); 124 124 } 125 125 126 126 static ssize_t manager_default_color_store(struct omap_overlay_manager *mgr, ··· 165 165 key_type = info.trans_key_type; 166 166 BUG_ON(key_type >= ARRAY_SIZE(trans_key_type_str)); 167 167 168 - return snprintf(buf, PAGE_SIZE, "%s\n", trans_key_type_str[key_type]); 168 + return sysfs_emit(buf, "%s\n", trans_key_type_str[key_type]); 169 169 } 170 170 171 171 static ssize_t manager_trans_key_type_store(struct omap_overlay_manager *mgr, ··· 200 200 201 201 mgr->get_manager_info(mgr, &info); 202 202 203 - return snprintf(buf, PAGE_SIZE, "%#x\n", info.trans_key); 203 + return sysfs_emit(buf, "%#x\n", info.trans_key); 204 204 } 205 205 206 206 static ssize_t manager_trans_key_value_store(struct omap_overlay_manager *mgr, ··· 236 236 237 237 mgr->get_manager_info(mgr, &info); 238 238 239 - return snprintf(buf, PAGE_SIZE, "%d\n", info.trans_enabled); 239 + return sysfs_emit(buf, "%d\n", info.trans_enabled); 240 240 } 241 241 242 242 static ssize_t manager_trans_key_enabled_store(struct omap_overlay_manager *mgr, ··· 275 275 276 276 mgr->get_manager_info(mgr, &info); 277 277 278 - return snprintf(buf, PAGE_SIZE, "%d\n", 278 + return sysfs_emit(buf, "%d\n", 279 279 info.partial_alpha_enabled); 280 280 } 281 281 ··· 316 316 317 317 mgr->get_manager_info(mgr, &info); 318 318 319 - return snprintf(buf, PAGE_SIZE, "%d\n", info.cpr_enable); 319 + return sysfs_emit(buf, "%d\n", info.cpr_enable); 320 320 } 321 321 322 322 static ssize_t manager_cpr_enable_store(struct omap_overlay_manager *mgr, ··· 358 358 359 359 mgr->get_manager_info(mgr, &info); 360 360 361 - return snprintf(buf, PAGE_SIZE, 361 + return sysfs_emit(buf, 362 362 "%d %d %d %d %d %d %d %d %d\n", 363 363 info.cpr_coefs.rr, 364 364 info.cpr_coefs.rg,
+10 -10
drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c
··· 22 22 23 23 static ssize_t overlay_name_show(struct omap_overlay *ovl, char *buf) 24 24 { 25 - return snprintf(buf, PAGE_SIZE, "%s\n", ovl->name); 25 + return sysfs_emit(buf, "%s\n", ovl->name); 26 26 } 27 27 28 28 static ssize_t overlay_manager_show(struct omap_overlay *ovl, char *buf) 29 29 { 30 - return snprintf(buf, PAGE_SIZE, "%s\n", 30 + return sysfs_emit(buf, "%s\n", 31 31 ovl->manager ? ovl->manager->name : "<none>"); 32 32 } 33 33 ··· 108 108 109 109 ovl->get_overlay_info(ovl, &info); 110 110 111 - return snprintf(buf, PAGE_SIZE, "%d,%d\n", 111 + return sysfs_emit(buf, "%d,%d\n", 112 112 info.width, info.height); 113 113 } 114 114 ··· 118 118 119 119 ovl->get_overlay_info(ovl, &info); 120 120 121 - return snprintf(buf, PAGE_SIZE, "%d\n", info.screen_width); 121 + return sysfs_emit(buf, "%d\n", info.screen_width); 122 122 } 123 123 124 124 static ssize_t overlay_position_show(struct omap_overlay *ovl, char *buf) ··· 127 127 128 128 ovl->get_overlay_info(ovl, &info); 129 129 130 - return snprintf(buf, PAGE_SIZE, "%d,%d\n", 130 + return sysfs_emit(buf, "%d,%d\n", 131 131 info.pos_x, info.pos_y); 132 132 } 133 133 ··· 166 166 167 167 ovl->get_overlay_info(ovl, &info); 168 168 169 - return snprintf(buf, PAGE_SIZE, "%d,%d\n", 169 + return sysfs_emit(buf, "%d,%d\n", 170 170 info.out_width, info.out_height); 171 171 } 172 172 ··· 201 201 202 202 static ssize_t overlay_enabled_show(struct omap_overlay *ovl, char *buf) 203 203 { 204 - return snprintf(buf, PAGE_SIZE, "%d\n", ovl->is_enabled(ovl)); 204 + return sysfs_emit(buf, "%d\n", ovl->is_enabled(ovl)); 205 205 } 206 206 207 207 static ssize_t overlay_enabled_store(struct omap_overlay *ovl, const char *buf, ··· 231 231 232 232 ovl->get_overlay_info(ovl, &info); 233 233 234 - return snprintf(buf, PAGE_SIZE, "%d\n", 234 + return sysfs_emit(buf, "%d\n", 235 235 info.global_alpha); 236 236 } 237 237 ··· 273 273 274 274 ovl->get_overlay_info(ovl, &info); 275 275 276 - return snprintf(buf, PAGE_SIZE, "%d\n", 276 + return sysfs_emit(buf, "%d\n", 277 277 info.pre_mult_alpha); 278 278 } 279 279 ··· 314 314 315 315 ovl->get_overlay_info(ovl, &info); 316 316 317 - return snprintf(buf, PAGE_SIZE, "%d\n", info.zorder); 317 + return sysfs_emit(buf, "%d\n", info.zorder); 318 318 } 319 319 320 320 static ssize_t overlay_zorder_store(struct omap_overlay *ovl,
+6 -6
drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c
··· 29 29 struct fb_info *fbi = dev_get_drvdata(dev); 30 30 struct omapfb_info *ofbi = FB2OFB(fbi); 31 31 32 - return snprintf(buf, PAGE_SIZE, "%d\n", ofbi->rotation_type); 32 + return sysfs_emit(buf, "%d\n", ofbi->rotation_type); 33 33 } 34 34 35 35 static ssize_t store_rotate_type(struct device *dev, ··· 83 83 struct fb_info *fbi = dev_get_drvdata(dev); 84 84 struct omapfb_info *ofbi = FB2OFB(fbi); 85 85 86 - return snprintf(buf, PAGE_SIZE, "%d\n", ofbi->mirror); 86 + return sysfs_emit(buf, "%d\n", ofbi->mirror); 87 87 } 88 88 89 89 static ssize_t store_mirror(struct device *dev, ··· 415 415 struct fb_info *fbi = dev_get_drvdata(dev); 416 416 struct omapfb_info *ofbi = FB2OFB(fbi); 417 417 418 - return snprintf(buf, PAGE_SIZE, "%lu\n", ofbi->region->size); 418 + return sysfs_emit(buf, "%lu\n", ofbi->region->size); 419 419 } 420 420 421 421 static ssize_t store_size(struct device *dev, struct device_attribute *attr, ··· 492 492 struct fb_info *fbi = dev_get_drvdata(dev); 493 493 struct omapfb_info *ofbi = FB2OFB(fbi); 494 494 495 - return snprintf(buf, PAGE_SIZE, "%0x\n", ofbi->region->paddr); 495 + return sysfs_emit(buf, "%0x\n", ofbi->region->paddr); 496 496 } 497 497 498 498 static ssize_t show_virt(struct device *dev, ··· 501 501 struct fb_info *fbi = dev_get_drvdata(dev); 502 502 struct omapfb_info *ofbi = FB2OFB(fbi); 503 503 504 - return snprintf(buf, PAGE_SIZE, "%p\n", ofbi->region->vaddr); 504 + return sysfs_emit(buf, "%p\n", ofbi->region->vaddr); 505 505 } 506 506 507 507 static ssize_t show_upd_mode(struct device *dev, ··· 516 516 if (r) 517 517 return r; 518 518 519 - return snprintf(buf, PAGE_SIZE, "%u\n", (unsigned)mode); 519 + return sysfs_emit(buf, "%u\n", (unsigned int)mode); 520 520 } 521 521 522 522 static ssize_t store_upd_mode(struct device *dev, struct device_attribute *attr,