Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: add free_hot_cold_page_list() helper

This patch adds helper free_hot_cold_page_list() to free list of 0-order
pages. It frees pages directly from list without temporary page-vector.
It also calls trace_mm_pagevec_free() to simulate pagevec_free()
behaviour.

bloat-o-meter:

add/remove: 1/1 grow/shrink: 1/3 up/down: 267/-295 (-28)
function old new delta
free_hot_cold_page_list - 264 +264
get_page_from_freelist 2129 2132 +3
__pagevec_free 243 239 -4
split_free_page 380 373 -7
release_pages 606 510 -96
free_page_list 188 - -188

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Minchan Kim <minchan.kim@gmail.com>
Acked-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Konstantin Khlebnikov and committed by
Linus Torvalds
cc59850e c909e993

+18 -30
+1
include/linux/gfp.h
··· 358 358 extern void __free_pages(struct page *page, unsigned int order); 359 359 extern void free_pages(unsigned long addr, unsigned int order); 360 360 extern void free_hot_cold_page(struct page *page, int cold); 361 + extern void free_hot_cold_page_list(struct list_head *list, int cold); 361 362 362 363 #define __free_page(page) __free_pages((page), 0) 363 364 #define free_page(addr) free_pages((addr), 0)
+13
mm/page_alloc.c
··· 1189 1189 } 1190 1190 1191 1191 /* 1192 + * Free a list of 0-order pages 1193 + */ 1194 + void free_hot_cold_page_list(struct list_head *list, int cold) 1195 + { 1196 + struct page *page, *next; 1197 + 1198 + list_for_each_entry_safe(page, next, list, lru) { 1199 + trace_mm_pagevec_free(page, cold); 1200 + free_hot_cold_page(page, cold); 1201 + } 1202 + } 1203 + 1204 + /* 1192 1205 * split_page takes a non-compound higher-order page, and splits it into 1193 1206 * n (1<<order) sub-pages: page[0..n] 1194 1207 * Each sub-page must be freed individually.
+3 -11
mm/swap.c
··· 585 585 void release_pages(struct page **pages, int nr, int cold) 586 586 { 587 587 int i; 588 - struct pagevec pages_to_free; 588 + LIST_HEAD(pages_to_free); 589 589 struct zone *zone = NULL; 590 590 unsigned long uninitialized_var(flags); 591 591 592 - pagevec_init(&pages_to_free, cold); 593 592 for (i = 0; i < nr; i++) { 594 593 struct page *page = pages[i]; 595 594 ··· 619 620 del_page_from_lru(zone, page); 620 621 } 621 622 622 - if (!pagevec_add(&pages_to_free, page)) { 623 - if (zone) { 624 - spin_unlock_irqrestore(&zone->lru_lock, flags); 625 - zone = NULL; 626 - } 627 - __pagevec_free(&pages_to_free); 628 - pagevec_reinit(&pages_to_free); 629 - } 623 + list_add(&page->lru, &pages_to_free); 630 624 } 631 625 if (zone) 632 626 spin_unlock_irqrestore(&zone->lru_lock, flags); 633 627 634 - pagevec_free(&pages_to_free); 628 + free_hot_cold_page_list(&pages_to_free, cold); 635 629 } 636 630 EXPORT_SYMBOL(release_pages); 637 631
+1 -19
mm/vmscan.c
··· 734 734 return PAGEREF_RECLAIM; 735 735 } 736 736 737 - static noinline_for_stack void free_page_list(struct list_head *free_pages) 738 - { 739 - struct pagevec freed_pvec; 740 - struct page *page, *tmp; 741 - 742 - pagevec_init(&freed_pvec, 1); 743 - 744 - list_for_each_entry_safe(page, tmp, free_pages, lru) { 745 - list_del(&page->lru); 746 - if (!pagevec_add(&freed_pvec, page)) { 747 - __pagevec_free(&freed_pvec); 748 - pagevec_reinit(&freed_pvec); 749 - } 750 - } 751 - 752 - pagevec_free(&freed_pvec); 753 - } 754 - 755 737 /* 756 738 * shrink_page_list() returns the number of reclaimed pages 757 739 */ ··· 997 1015 if (nr_dirty && nr_dirty == nr_congested && scanning_global_lru(sc)) 998 1016 zone_set_flag(zone, ZONE_CONGESTED); 999 1017 1000 - free_page_list(&free_pages); 1018 + free_hot_cold_page_list(&free_pages, 1); 1001 1019 1002 1020 list_splice(&ret_pages, page_list); 1003 1021 count_vm_events(PGACTIVATE, pgactivate);