Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: imon: Convert sprintf/snprintf to sysfs_emit

Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Li Zhijian and committed by
Hans Verkuil
cc4cce95 8d93d067

+6 -6
+6 -6
drivers/media/rc/imon.c
··· 845 845 mutex_lock(&ictx->lock); 846 846 847 847 if (!ictx->display_supported) { 848 - len = snprintf(buf, PAGE_SIZE, "Not supported."); 848 + len = sysfs_emit(buf, "Not supported."); 849 849 } else { 850 - len = snprintf(buf, PAGE_SIZE, 851 - "To set the clock on your iMON display:\n" 852 - "# date \"+%%y %%m %%d %%w %%H %%M %%S\" > imon_clock\n" 853 - "%s", ictx->display_isopen ? 854 - "\nNOTE: imon device must be closed\n" : ""); 850 + len = sysfs_emit(buf, 851 + "To set the clock on your iMON display:\n" 852 + "# date \"+%%y %%m %%d %%w %%H %%M %%S\" > imon_clock\n" 853 + "%s", ictx->display_isopen ? 854 + "\nNOTE: imon device must be closed\n" : ""); 855 855 } 856 856 857 857 mutex_unlock(&ictx->lock);