Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dm raid: fix discard limits for raid1

Block core warned that discard_granularity was 0 for dm-raid with
personality of raid1. Reason is that raid_io_hints() was incorrectly
special-casing raid1 rather than raid0.

Fix raid_io_hints() by removing discard limits settings for
raid1. Check for raid0 instead.

Fixes: 61697a6abd24a ("dm: eliminate 'split_discard_bios' flag from DM target interface")
Cc: stable@vger.kernel.org
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Reported-by: Stephan Bärwolf <stephan@matrixstorm.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

+3 -3
+3 -3
drivers/md/dm-raid.c
··· 3729 3729 blk_limits_io_opt(limits, chunk_size_bytes * mddev_data_stripes(rs)); 3730 3730 3731 3731 /* 3732 - * RAID1 and RAID10 personalities require bio splitting, 3733 - * RAID0/4/5/6 don't and process large discard bios properly. 3732 + * RAID0 and RAID10 personalities require bio splitting, 3733 + * RAID1/4/5/6 don't and process large discard bios properly. 3734 3734 */ 3735 - if (rs_is_raid1(rs) || rs_is_raid10(rs)) { 3735 + if (rs_is_raid0(rs) || rs_is_raid10(rs)) { 3736 3736 limits->discard_granularity = chunk_size_bytes; 3737 3737 limits->max_discard_sectors = rs->md.chunk_sectors; 3738 3738 }