Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: ktd2692: avoid harmless maybe-uninitialized warning

gcc gets confused about the control flow in ktd2692_parse_dt(), causing
it to warn about what seems like a potential bug:

drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The code is fine, and slightly reworking it in an equivalent way lets
gcc figure that out too, which gets rid of the warning.

Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

authored by

Arnd Bergmann and committed by
Jacek Anaszewski
cbe99c53 4e552c8c

+4 -4
+4 -4
drivers/leds/leds-ktd2692.c
··· 270 270 return -ENXIO; 271 271 272 272 led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS); 273 - if (IS_ERR(led->ctrl_gpio)) { 274 - ret = PTR_ERR(led->ctrl_gpio); 273 + ret = PTR_ERR_OR_ZERO(led->ctrl_gpio); 274 + if (ret) { 275 275 dev_err(dev, "cannot get ctrl-gpios %d\n", ret); 276 276 return ret; 277 277 } 278 278 279 279 led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS); 280 - if (IS_ERR(led->aux_gpio)) { 281 - ret = PTR_ERR(led->aux_gpio); 280 + ret = PTR_ERR_OR_ZERO(led->aux_gpio); 281 + if (ret) { 282 282 dev_err(dev, "cannot get aux-gpios %d\n", ret); 283 283 return ret; 284 284 }