Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net/usb/kalmia: use %*phC to dump small buffers

Instead of dereferencing pointer and put values on stack we could use nice
%*phC specifier.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Andy Shevchenko and committed by
David S. Miller
cbb963de d6641ccf

+15 -30
+15 -30
drivers/net/usb/kalmia.c
··· 221 221 memset(skb_put(skb, padlen), 0, padlen); 222 222 } 223 223 224 - netdev_dbg( 225 - dev->net, 226 - "Sending package with length %i and padding %i. Header: %02x:%02x:%02x:%02x:%02x:%02x.", 227 - content_len, padlen, header_start[0], header_start[1], 228 - header_start[2], header_start[3], header_start[4], 229 - header_start[5]); 224 + netdev_dbg(dev->net, 225 + "Sending package with length %i and padding %i. Header: %6phC.", 226 + content_len, padlen, header_start); 230 227 231 228 return skb; 232 229 } ··· 260 263 sizeof(EXPECTED_UNKNOWN_HEADER_1)) || !memcmp( 261 264 header_start, EXPECTED_UNKNOWN_HEADER_2, 262 265 sizeof(EXPECTED_UNKNOWN_HEADER_2))) { 263 - netdev_dbg( 264 - dev->net, 265 - "Received expected unknown frame header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n", 266 - header_start[0], header_start[1], 267 - header_start[2], header_start[3], 268 - header_start[4], header_start[5], 266 + netdev_dbg(dev->net, 267 + "Received expected unknown frame header: %6phC. Package length: %i\n", 268 + header_start, 269 269 skb->len - KALMIA_HEADER_LENGTH); 270 270 } 271 271 else { 272 - netdev_err( 273 - dev->net, 274 - "Received unknown frame header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n", 275 - header_start[0], header_start[1], 276 - header_start[2], header_start[3], 277 - header_start[4], header_start[5], 272 + netdev_err(dev->net, 273 + "Received unknown frame header: %6phC. Package length: %i\n", 274 + header_start, 278 275 skb->len - KALMIA_HEADER_LENGTH); 279 276 return 0; 280 277 } 281 278 } 282 279 else 283 - netdev_dbg( 284 - dev->net, 285 - "Received header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n", 286 - header_start[0], header_start[1], header_start[2], 287 - header_start[3], header_start[4], header_start[5], 288 - skb->len - KALMIA_HEADER_LENGTH); 280 + netdev_dbg(dev->net, 281 + "Received header: %6phC. Package length: %i\n", 282 + header_start, skb->len - KALMIA_HEADER_LENGTH); 289 283 290 284 /* subtract start header and end header */ 291 285 usb_packet_length = skb->len - (2 * KALMIA_HEADER_LENGTH); ··· 298 310 sizeof(HEADER_END_OF_USB_PACKET)) == 0); 299 311 if (!is_last) { 300 312 header_start = skb->data + ether_packet_length; 301 - netdev_dbg( 302 - dev->net, 303 - "End header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n", 304 - header_start[0], header_start[1], 305 - header_start[2], header_start[3], 306 - header_start[4], header_start[5], 313 + netdev_dbg(dev->net, 314 + "End header: %6phC. Package length: %i\n", 315 + header_start, 307 316 skb->len - KALMIA_HEADER_LENGTH); 308 317 } 309 318 }