Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: r8188eu: remove comments in update_recvframe_attrib_88e

Remove a couple of comments in update_recvframe_attrib_88e that provide no
useful information.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220305144117.1380534-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Martin Kaiser and committed by
Greg Kroah-Hartman
cb9d4390 49571c57

+22 -26
+22 -26
drivers/staging/r8188eu/hal/rtl8188e_rxdesc.c
··· 60 60 struct rx_pkt_attrib *pattrib = &precvframe->attrib; 61 61 memset(pattrib, 0, sizeof(struct rx_pkt_attrib)); 62 62 63 - pattrib->crc_err = (le32_to_cpu(prxstat->rxdw0) >> 14) & 0x1;/* u8)prxreport->crc32; */ 63 + pattrib->crc_err = (le32_to_cpu(prxstat->rxdw0) >> 14) & 0x1; 64 64 65 - /* update rx report to recv_frame attribute */ 66 - pattrib->pkt_rpt_type = (le32_to_cpu(prxstat->rxdw3) >> 14) & 0x3;/* prxreport->rpt_sel; */ 65 + pattrib->pkt_rpt_type = (le32_to_cpu(prxstat->rxdw3) >> 14) & 0x3; 67 66 68 - if (pattrib->pkt_rpt_type == NORMAL_RX) { /* Normal rx packet */ 69 - pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x00003fff;/* u16)prxreport->pktlen; */ 70 - pattrib->drvinfo_sz = ((le32_to_cpu(prxstat->rxdw0) >> 16) & 0xf) * 8;/* u8)(prxreport->drvinfosize << 3); */ 67 + if (pattrib->pkt_rpt_type == NORMAL_RX) { 68 + pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x00003fff; 69 + pattrib->drvinfo_sz = ((le32_to_cpu(prxstat->rxdw0) >> 16) & 0xf) * 8; 71 70 72 - pattrib->physt = (le32_to_cpu(prxstat->rxdw0) >> 26) & 0x1;/* u8)prxreport->physt; */ 71 + pattrib->physt = (le32_to_cpu(prxstat->rxdw0) >> 26) & 0x1; 73 72 74 - pattrib->bdecrypted = (le32_to_cpu(prxstat->rxdw0) & BIT(27)) ? 0 : 1;/* u8)(prxreport->swdec ? 0 : 1); */ 75 - pattrib->encrypt = (le32_to_cpu(prxstat->rxdw0) >> 20) & 0x7;/* u8)prxreport->security; */ 73 + pattrib->bdecrypted = (le32_to_cpu(prxstat->rxdw0) & BIT(27)) ? 0 : 1; 74 + pattrib->encrypt = (le32_to_cpu(prxstat->rxdw0) >> 20) & 0x7; 76 75 77 - pattrib->qos = (le32_to_cpu(prxstat->rxdw0) >> 23) & 0x1;/* prxreport->qos; */ 78 - pattrib->priority = (le32_to_cpu(prxstat->rxdw1) >> 8) & 0xf;/* u8)prxreport->tid; */ 76 + pattrib->qos = (le32_to_cpu(prxstat->rxdw0) >> 23) & 0x1; 77 + pattrib->priority = (le32_to_cpu(prxstat->rxdw1) >> 8) & 0xf; 79 78 80 - pattrib->amsdu = (le32_to_cpu(prxstat->rxdw1) >> 13) & 0x1;/* u8)prxreport->amsdu; */ 79 + pattrib->amsdu = (le32_to_cpu(prxstat->rxdw1) >> 13) & 0x1; 81 80 82 - pattrib->seq_num = le32_to_cpu(prxstat->rxdw2) & 0x00000fff;/* u16)prxreport->seq; */ 83 - pattrib->frag_num = (le32_to_cpu(prxstat->rxdw2) >> 12) & 0xf;/* u8)prxreport->frag; */ 84 - pattrib->mfrag = (le32_to_cpu(prxstat->rxdw1) >> 27) & 0x1;/* u8)prxreport->mf; */ 85 - pattrib->mdata = (le32_to_cpu(prxstat->rxdw1) >> 26) & 0x1;/* u8)prxreport->md; */ 81 + pattrib->seq_num = le32_to_cpu(prxstat->rxdw2) & 0x00000fff; 82 + pattrib->frag_num = (le32_to_cpu(prxstat->rxdw2) >> 12) & 0xf; 83 + pattrib->mfrag = (le32_to_cpu(prxstat->rxdw1) >> 27) & 0x1; 84 + pattrib->mdata = (le32_to_cpu(prxstat->rxdw1) >> 26) & 0x1; 86 85 87 - pattrib->mcs_rate = le32_to_cpu(prxstat->rxdw3) & 0x3f;/* u8)prxreport->rxmcs; */ 88 - pattrib->rxht = (le32_to_cpu(prxstat->rxdw3) >> 6) & 0x1;/* u8)prxreport->rxht; */ 86 + pattrib->mcs_rate = le32_to_cpu(prxstat->rxdw3) & 0x3f; 87 + pattrib->rxht = (le32_to_cpu(prxstat->rxdw3) >> 6) & 0x1; 89 88 90 - pattrib->icv_err = (le32_to_cpu(prxstat->rxdw0) >> 15) & 0x1;/* u8)prxreport->icverr; */ 89 + pattrib->icv_err = (le32_to_cpu(prxstat->rxdw0) >> 15) & 0x1; 91 90 pattrib->shift_sz = (le32_to_cpu(prxstat->rxdw0) >> 24) & 0x3; 92 91 } else if (pattrib->pkt_rpt_type == TX_REPORT1) { /* CCX */ 93 92 pattrib->pkt_len = TX_RPT1_PKT_LEN; 94 - } else if (pattrib->pkt_rpt_type == TX_REPORT2) { /* TX RPT */ 95 - pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x3FF;/* Rx length[9:0] */ 93 + } else if (pattrib->pkt_rpt_type == TX_REPORT2) { 94 + pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x3FF; 96 95 97 - /* */ 98 - /* Get TX report MAC ID valid. */ 99 - /* */ 100 96 pattrib->MacIDValidEntry[0] = le32_to_cpu(prxstat->rxdw4); 101 97 pattrib->MacIDValidEntry[1] = le32_to_cpu(prxstat->rxdw5); 102 98 103 - } else if (pattrib->pkt_rpt_type == HIS_REPORT) { /* USB HISR RPT */ 104 - pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x00003fff;/* u16)prxreport->pktlen; */ 99 + } else if (pattrib->pkt_rpt_type == HIS_REPORT) { 100 + pattrib->pkt_len = le32_to_cpu(prxstat->rxdw0) & 0x00003fff; 105 101 } 106 102 } 107 103