Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cifs: mapchars mount option ignored

There are two ways that special characters (not allowed in some
other operating systems like Windows, but allowed in POSIX) have
been mapped in the past ("SFU" and "SFM" mappings) to allow them
to be stored in a range reserved for special chars. The default
for Linux has been to use "mapposix" (ie the SFM mapping) but
the conversion to the new mount API in the 5.11 kernel broke
the ability to override the default mapping of the reserved
characters (like '?' and '*' and '\') via "mapchars" mount option.

This patch fixes that - so can now mount with "mapchars"
mount option to override the default ("mapposix" ie SFM) mapping.

Reported-by: Tyler Spivey <tspivey8@gmail.com>
Fixes: 24e0a1eff9e2 ("cifs: switch to new mount api")
Signed-off-by: Steve French <stfrench@microsoft.com>

+8
+8
fs/cifs/fs_context.c
··· 904 904 ctx->sfu_remap = false; /* disable SFU mapping */ 905 905 } 906 906 break; 907 + case Opt_mapchars: 908 + if (result.negated) 909 + ctx->sfu_remap = false; 910 + else { 911 + ctx->sfu_remap = true; 912 + ctx->remap = false; /* disable SFM (mapposix) mapping */ 913 + } 914 + break; 907 915 case Opt_user_xattr: 908 916 if (result.negated) 909 917 ctx->no_xattr = 1;