Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kdump: define KEXEC_NOTE_BYTES arch specific for s390x

kdump only allocates memory for the prstatus ELF note. For s390x,
besides of prstatus multiple ELF notes for various different register
types are stored. Therefore the currently allocated memory is not
sufficient. With this patch the KEXEC_NOTE_BYTES macro can be defined
by architecture code and for s390x it is set to the correct size now.

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Michael Holzheu and committed by
Linus Torvalds
cb78edfd 409eb8c2

+20
+18
arch/s390/include/asm/kexec.h
··· 42 42 /* The native architecture */ 43 43 #define KEXEC_ARCH KEXEC_ARCH_S390 44 44 45 + /* 46 + * Size for s390x ELF notes per CPU 47 + * 48 + * Seven notes plus zero note at the end: prstatus, fpregset, timer, 49 + * tod_cmp, tod_reg, control regs, and prefix 50 + */ 51 + #define KEXEC_NOTE_BYTES \ 52 + (ALIGN(sizeof(struct elf_note), 4) * 8 + \ 53 + ALIGN(sizeof("CORE"), 4) * 7 + \ 54 + ALIGN(sizeof(struct elf_prstatus), 4) + \ 55 + ALIGN(sizeof(elf_fpregset_t), 4) + \ 56 + ALIGN(sizeof(u64), 4) + \ 57 + ALIGN(sizeof(u64), 4) + \ 58 + ALIGN(sizeof(u32), 4) + \ 59 + ALIGN(sizeof(u64) * 16, 4) + \ 60 + ALIGN(sizeof(u32), 4) \ 61 + ) 62 + 45 63 /* Provide a dummy definition to avoid build failures. */ 46 64 static inline void crash_setup_regs(struct pt_regs *newregs, 47 65 struct pt_regs *oldregs) { }
+2
include/linux/kexec.h
··· 50 50 * note header. For kdump, the code in vmcore.c runs in the context 51 51 * of the second kernel to combine them into one note. 52 52 */ 53 + #ifndef KEXEC_NOTE_BYTES 53 54 #define KEXEC_NOTE_BYTES ( (KEXEC_NOTE_HEAD_BYTES * 2) + \ 54 55 KEXEC_CORE_NOTE_NAME_BYTES + \ 55 56 KEXEC_CORE_NOTE_DESC_BYTES ) 57 + #endif 56 58 57 59 /* 58 60 * This structure is used to hold the arguments that are used when loading