Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipv6:fix checkpatch errors with assignment in if condition

Signed-off-by: Wang Yufen <wangyufen@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Wang Yufen and committed by
David S. Miller
cb6e926e 1c8669e0

+9 -7
+9 -7
net/ipv6/addrlabel.c
··· 504 504 hlist_for_each_entry_rcu(p, &ip6addrlbl_table.head, list) { 505 505 if (idx >= s_idx && 506 506 net_eq(ip6addrlbl_net(p), net)) { 507 - if ((err = ip6addrlbl_fill(skb, p, 508 - ip6addrlbl_table.seq, 509 - NETLINK_CB(cb->skb).portid, 510 - cb->nlh->nlmsg_seq, 511 - RTM_NEWADDRLABEL, 512 - NLM_F_MULTI)) <= 0) 507 + err = ip6addrlbl_fill(skb, p, 508 + ip6addrlbl_table.seq, 509 + NETLINK_CB(cb->skb).portid, 510 + cb->nlh->nlmsg_seq, 511 + RTM_NEWADDRLABEL, 512 + NLM_F_MULTI); 513 + if (err <= 0) 513 514 break; 514 515 } 515 516 idx++; ··· 568 567 goto out; 569 568 } 570 569 571 - if (!(skb = nlmsg_new(ip6addrlbl_msgsize(), GFP_KERNEL))) { 570 + skb = nlmsg_new(ip6addrlbl_msgsize(), GFP_KERNEL); 571 + if (!skb) { 572 572 ip6addrlbl_put(p); 573 573 return -ENOBUFS; 574 574 }